Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Unified Diff: content/common/notification_service_unittest.cc

Issue 7465041: GTTF: Use a fresh TestingBrowserProcess for each test, part #4 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: should work Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/common/DEPS ('K') | « content/common/DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/notification_service_unittest.cc
diff --git a/content/common/notification_service_unittest.cc b/content/common/notification_service_unittest.cc
index a40e11c0e9487d4697fff11ede08836588a9762f..b673007a0ab8b16b4f1dd93077962c4bba54c8cb 100644
--- a/content/common/notification_service_unittest.cc
+++ b/content/common/notification_service_unittest.cc
@@ -5,6 +5,7 @@
#include "content/common/notification_observer.h"
#include "content/common/notification_registrar.h"
#include "content/common/notification_service.h"
+#include "chrome/test/testing_browser_process_test.h"
sky 2011/07/28 00:28:03 nit: before content
#include "testing/gtest/include/gtest/gtest.h"
namespace {
@@ -31,7 +32,7 @@ private:
} // namespace
-class NotificationServiceTest : public testing::Test {
+class NotificationServiceTest : public TestingBrowserProcessTest {
jam 2011/07/28 01:41:21 why should a unit test derive from BrowserProcessT
Paweł Hajdan Jr. 2011/07/28 03:49:18 TestingBrowserProcess has nothing to do with brows
jam 2011/07/28 16:48:54 I see, although I'm not sure I understand why unit
protected:
NotificationRegistrar registrar_;
};
« content/common/DEPS ('K') | « content/common/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698