GTTF: Use a fresh TestingBrowserProcess for each test, part #4

content/common/notification_service_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/notification_observer.h"
 #include "content/common/notification_registrar.h"
 #include "content/common/notification_service.h"
+#include "chrome/test/testing_browser_process_test.h"

[sky, 2011/07/28 00:28:03]

nit: before content

 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 // Bogus class to act as a NotificationSource for the messages.
 class TestSource {};
 
 class TestObserver : public NotificationObserver {
 public:
   TestObserver() : notification_count_(0) {}
 
   int notification_count() { return notification_count_; }
 
   void Observe(int type,
                const NotificationSource& source,
                const NotificationDetails& details) {
     ++notification_count_;
   }
 
 private:
   int notification_count_;
 };
 
 }  // namespace
 
 
-class NotificationServiceTest : public testing::Test {
+class NotificationServiceTest : public TestingBrowserProcessTest {

[jam, 2011/07/28 01:41:21]

why should a unit test derive from BrowserProcessTest? or is that something
you'll do in a future cl?

[Paweł Hajdan Jr., 2011/07/28 03:49:18]

TestingBrowserProcess has nothing to do with browser tests or
InProcessBrowserTest. Sorry for the confusion; the main idea here is that we
mock out the BrowserProcess object stored in g_browser_process.

[jam, 2011/07/28 16:48:54]

I see, although I'm not sure I understand why unit tests need a BrowserProcess
object around. But we can leave this until we start working on content_unittests

  protected:
   NotificationRegistrar registrar_;
 };
 
 TEST_F(NotificationServiceTest, Basic) {
   TestSource test_source;
   TestSource other_source;
 
   // Check the equality operators defined for NotificationSource
   EXPECT_TRUE(
@@ skipping 110 matching lines @@
   EXPECT_EQ(3, idle_test_source.notification_count());
 
   registrar_.Remove(&idle_test_source, content::NOTIFICATION_ALL,
                     Source<TestSource>(&test_source));
 
   service->Notify(content::NOTIFICATION_IDLE,
                   Source<TestSource>(&test_source),
                   NotificationService::NoDetails());
   EXPECT_EQ(3, idle_test_source.notification_count());
 }