Installer for Windows cloud print driver changed to use PPD, PPd file added

Installer for Windows cloud print driver changed to use PPD, PPd file added


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95520

[Scott Byer, 2011-07-21 00:55:22]

I think, in general, we're going to want to have a discussion about what wants
to go into this file, especially regarding paper sizes and image-able areas.

http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
File cloud_print/virtual_driver/GCP-driver.ppd (right):

http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
cloud_print/virtual_driver/GCP-driver.ppd:15: *% cupsFilter:   
"application/vnd.cups-postscript 0 pstopdf"
remove comment?

http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
cloud_print/virtual_driver/GCP-driver.ppd:26: *VariablePaperSize: False
Remove obsolete key.

http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
cloud_print/virtual_driver/GCP-driver.ppd:40: 
nit: extra empty line

http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
cloud_print/virtual_driver/GCP-driver.ppd:62: *DefaultResolution: 2400dpi
I don't think we want to claim so high on the DPI, in case an upstream app wants
to re-sample images itself. I'd suggest 600 or 300 as a default, you may want to
consult Paolo.

http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
cloud_print/virtual_driver/GCP-driver.ppd:63: *Resolution 2400dpi/2400 DPI:
"<</HWResolution[2400 2400]>>setpagedevice"
I think we should have several of these, to match our expected CUPS raster
output resolutions - 300, 340, 600. The idea again being that have a reasonable
set may prevent unwanted upstream re-sampling of images.

http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
cloud_print/virtual_driver/GCP-driver.ppd:69: *Font AvantGarde-Book: Standard
"(001.006S)" Standard ROM
Does this font list match what our PDF converter has installed? Otherwise
producers won't have a chance to properly embed fonts.

[abeera, 2011-07-28 21:40:57]

I updated the PPD file as per the review. I talked to Paolo, and it turns out I
can remove a lot of things from the PPD. I can safely ignore the resolution and
fonts list.
On 2011/07/21 00:55:22, Scott Byer wrote:
> I think, in general, we're going to want to have a discussion about what wants
> to go into this file, especially regarding paper sizes and image-able areas.
> 
>
http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
> File cloud_print/virtual_driver/GCP-driver.ppd (right):
> 
>
http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
> cloud_print/virtual_driver/GCP-driver.ppd:15: *% cupsFilter:   
> "application/vnd.cups-postscript 0 pstopdf"
> remove comment?
> 
>
http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
> cloud_print/virtual_driver/GCP-driver.ppd:26: *VariablePaperSize: False
> Remove obsolete key.
> 
>
http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
> cloud_print/virtual_driver/GCP-driver.ppd:40: 
> nit: extra empty line
> 
>
http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
> cloud_print/virtual_driver/GCP-driver.ppd:62: *DefaultResolution: 2400dpi
> I don't think we want to claim so high on the DPI, in case an upstream app
wants
> to re-sample images itself. I'd suggest 600 or 300 as a default, you may want
to
> consult Paolo.
> 
>
http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
> cloud_print/virtual_driver/GCP-driver.ppd:63: *Resolution 2400dpi/2400 DPI:
> "<</HWResolution[2400 2400]>>setpagedevice"
> I think we should have several of these, to match our expected CUPS raster
> output resolutions - 300, 340, 600. The idea again being that have a
reasonable
> set may prevent unwanted upstream re-sampling of images.
> 
>
http://codereview.chromium.org/7465016/diff/1/cloud_print/virtual_driver/GCP-...
> cloud_print/virtual_driver/GCP-driver.ppd:69: *Font AvantGarde-Book: Standard
> "(001.006S)" Standard ROM
> Does this font list match what our PDF converter has installed? Otherwise
> producers won't have a chance to properly embed fonts.

[Albert Bodenhamer, 2011-07-28 21:42:00]

LGTM for the setup.cc changes other than a minor nit.

I'll defer to Scott on the PPD changes.

http://codereview.chromium.org/7465016/diff/7001/cloud_print/virtual_driver/w...
File cloud_print/virtual_driver/win/install/setup.cc (right):

http://codereview.chromium.org/7465016/diff/7001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/install/setup.cc:153: FilePath ui_path =
driver_dir.Append(L"PS5UI.DLL");
Use lowercase file name.

[abeera, 2011-07-28 21:49:47]

http://codereview.chromium.org/7465016/diff/7001/cloud_print/virtual_driver/w...
File cloud_print/virtual_driver/win/install/setup.cc (right):

http://codereview.chromium.org/7465016/diff/7001/cloud_print/virtual_driver/w...
cloud_print/virtual_driver/win/install/setup.cc:153: FilePath ui_path =
driver_dir.Append(L"PS5UI.DLL");
Done
On 2011/07/28 21:42:00, Albert Bodenhamer wrote:
> Use lowercase file name.

[Scott Byer, 2011-08-04 20:46:53]

LGTM

On 2011/07/28 21:49:47, abeera wrote:
>
http://codereview.chromium.org/7465016/diff/7001/cloud_print/virtual_driver/w...
> File cloud_print/virtual_driver/win/install/setup.cc (right):
> 
>
http://codereview.chromium.org/7465016/diff/7001/cloud_print/virtual_driver/w...
> cloud_print/virtual_driver/win/install/setup.cc:153: FilePath ui_path =
> driver_dir.Append(L"PS5UI.DLL");
> Done
> On 2011/07/28 21:42:00, Albert Bodenhamer wrote:
> > Use lowercase file name.

[commit-bot: I haz the power, 2011-08-04 22:24:35]

Change committed as 95520