Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 7464029: Adding QuotaManager logic to TestingProfile. (Closed)

Created:
9 years, 5 months ago by Mike West
Modified:
9 years, 5 months ago
Reviewers:
michaeln, kinuko, marja
CC:
chromium-reviews, Paweł Hajdan Jr., tzik
Visibility:
Public.

Description

Adding QuotaManager logic to TestingProfile. BUG=63700 TEST=unit_tests

Patch Set 1 #

Total comments: 3

Patch Set 2 : Maybe working. Trybots? #

Patch Set 3 : Explicitly calling init. on IO thread. #

Patch Set 4 : Uglay. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -44 lines) Patch
M chrome/browser/browsing_data_remover_unittest.cc View 1 1 chunk +8 lines, -13 lines 0 comments Download
M chrome/test/testing_profile.h View 1 3 5 chunks +14 lines, -2 lines 0 comments Download
M chrome/test/testing_profile.cc View 1 2 3 6 chunks +71 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike West
9 years, 5 months ago (2011-07-21 14:46:12 UTC) #1
Mike West
marja: Can you review the change to the appcache tests in the BrowsingDataRemoverTest code? Not ...
9 years, 5 months ago (2011-07-21 14:50:32 UTC) #2
marja
On 2011/07/21 14:50:32, Mike West wrote: > marja: Can you review the change to the ...
9 years, 5 months ago (2011-07-21 14:59:05 UTC) #3
Mike West
Yaks need shaving with regard to threading in the testing profile; I'm doing my best ...
9 years, 5 months ago (2011-07-21 19:37:22 UTC) #4
michaeln
Please see my comments in http://codereview.chromium.org/7129018/, i think changes along these line may not be ...
9 years, 5 months ago (2011-07-22 00:09:58 UTC) #5
Mike West
9 years, 5 months ago (2011-07-26 07:53:20 UTC) #6
Rolling this into http://codereview.chromium.org/7129018/, closing the review.

Marja, you should probably take a look at that review, as I've thrown away all
the appcache-specific code in the BrowsingDataRemover: QuotaManager is handling
it now. :)

Powered by Google App Engine
This is Rietveld 408576698