Adding QuotaManager logic to TestingProfile.

chrome/browser/browsing_data_remover_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data_remover.h"
 
 #include <set>
 
 #include "base/message_loop.h"
 #include "base/platform_file.h"
@@ skipping 343 matching lines @@
       fileapi::kFileSystemTypePersistent));
   EXPECT_FALSE(tester->FileSystemContainsOriginAndType(kOrigin2,
       fileapi::kFileSystemTypeTemporary));
   EXPECT_FALSE(tester->FileSystemContainsOriginAndType(kOrigin3,
       fileapi::kFileSystemTypePersistent));
   EXPECT_FALSE(tester->FileSystemContainsOriginAndType(kOrigin3,
       fileapi::kFileSystemTypeTemporary));
 }
 
 TEST_F(BrowsingDataRemoverTest, RemoveAppCacheForever) {
-  // Set up ChromeAppCacheService.
-  scoped_refptr<ChromeAppCacheService> appcache_service =
-      new ChromeAppCacheService(NULL);
-  const content::ResourceContext* resource_context = NULL;
+  // Set up ChromeAppCacheService with a single protected origin
   scoped_refptr<MockExtensionSpecialStoragePolicy> mock_policy =
       new MockExtensionSpecialStoragePolicy;
   mock_policy->AddProtected(kProtectedManifest.GetOrigin());
-  BrowserThread::PostTask(
-      BrowserThread::IO, FROM_HERE,
-      NewRunnableMethod(appcache_service.get(),
-                        &ChromeAppCacheService::InitializeOnIOThread,
-                        FilePath(),
-                        resource_context,
-                        mock_policy,
-                        false));
-  MessageLoop::current()->RunAllPending();

[michaeln, 2011/07/22 00:09:58]

the call is RunAllPending is gone now... is that ok?

+  GetProfile()->SetExtensionSpecialStoragePolicy(mock_policy);
+  scoped_refptr<ChromeAppCacheService> appcache_service =
+      GetProfile()->GetAppCacheService();
+
   TestingProfile* profile = GetProfile();
-  profile->SetAppCacheService(appcache_service);
   profile->SetExtensionSpecialStoragePolicy(mock_policy);

[michaeln, 2011/07/22 00:09:58]

since the policy is now set up on line 368, no longer needed?

 
   // Add data into the AppCacheStorage.
   AppCacheInserter appcache_inserter;
   appcache_inserter.AddGroupAndCache(appcache_service, kNormalManifest);
   appcache_inserter.AddGroupAndCache(appcache_service, kProtectedManifest);
 
   // Verify that adding the data succeeded.
   AppCacheReader reader(appcache_service);
   std::set<GURL>* origins = reader.ReadAppCaches();
   EXPECT_EQ(2UL, origins->size());
   EXPECT_TRUE(origins->find(kProtectedManifest.GetOrigin()) != origins->end());
   EXPECT_TRUE(origins->find(kNormalManifest.GetOrigin()) != origins->end());
 
   // Set up the object to be tested.
   scoped_ptr<BrowsingDataRemoverTester> tester(new BrowsingDataRemoverTester());
   BrowsingDataRemover* remover = new BrowsingDataRemover(
       profile, BrowsingDataRemover::EVERYTHING, base::Time::Now());

[michaeln, 2011/07/22 00:09:58]

maybe use GetProfile() here now instead of 'profile' and get rid of the local

   remover->AddObserver(tester.get());
 
   // Remove the appcaches and wait for it to complete. BrowsingDataRemover
   // deletes itself when it completes.
   remover->Remove(BrowsingDataRemover::REMOVE_COOKIES);
   tester->BlockUntilNotified();
 
   // Results: appcaches for the normal origin got deleted, appcaches for the
   // protected origin didn't.
   origins = reader.ReadAppCaches();
   EXPECT_EQ(1UL, origins->size());
   EXPECT_TRUE(origins->find(kProtectedManifest.GetOrigin()) != origins->end());
 }
 
 }  // namespace