Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7461136: Convert HtmlDialogUIDelegate::GetDialogTitle() to string16. (Closed)

Created:
9 years, 4 months ago by tony
Modified:
9 years, 4 months ago
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Convert HtmlDialogUIDelegate::GetDialogTitle() to string16. Also sprinkle in some OVERRIDEs. It's not strictly necessary in this case since it's a pure virtual method, but it doesn't hurt and may help for future refactorings. BUG=23581 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95665

Patch Set 1 #

Patch Set 2 : compile errors #

Patch Set 3 : more fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -147 lines) Patch
M chrome/browser/browser_signin.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/choose_mobile_network_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/choose_mobile_network_dialog.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_html_dialog.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_html_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/sim_dialog_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/sim_dialog_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.h View 1 chunk +11 lines, -10 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_internal.h View 1 chunk +11 lines, -10 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/html_dialog_window_controller.mm View 3 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/html_dialog_window_controller_unittest.mm View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/html_dialog_gtk.h View 1 chunk +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/gtk/html_dialog_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/html_dialog_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/html_dialog_view.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/html_dialog_view_browsertest.cc View 1 2 2 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_delegate.h View 1 chunk +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog.cc View 4 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/collected_cookies_ui_delegate.h View 1 chunk +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/collected_cookies_ui_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/constrained_html_ui_browsertest.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/html_dialog_ui.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/task_manager_dialog.cc View 1 chunk +12 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
The test failures seem to all be flaky tests.
9 years, 4 months ago (2011-08-05 17:27:11 UTC) #1
Evan Martin
LGTM
9 years, 4 months ago (2011-08-05 17:40:26 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-05 21:49:09 UTC) #3 
Change committed as 95665

Powered by Google App Engine
This is Rietveld 408576698