chrome/browser/printing/cloud_print/cloud_print_setup_flow.h - Issue 7461136: Convert HtmlDialogUIDelegate::GetDialogTitle() to string16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_setup_flow.h

Issue 7461136: Convert HtmlDialogUIDelegate::GetDialogTitle() to string16. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more fixes Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/cloud_print/cloud_print_setup_flow.h

diff --git a/chrome/browser/printing/cloud_print/cloud_print_setup_flow.h b/chrome/browser/printing/cloud_print/cloud_print_setup_flow.h

index d532c60668ea84e130aa0267ff69f07f4b29ddc8..3dd84dc79c62f1364a4d9e9701d7ce5b8a5b781b 100644

--- a/chrome/browser/printing/cloud_print/cloud_print_setup_flow.h

+++ b/chrome/browser/printing/cloud_print/cloud_print_setup_flow.h

@@ -69,17 +69,18 @@ class CloudPrintSetupFlow : public HtmlDialogUIDelegate,

void Focus();

// HtmlDialogUIDelegate implementation.

- virtual GURL GetDialogContentURL() const;

+ virtual GURL GetDialogContentURL() const OVERRIDE;

virtual void GetWebUIMessageHandlers(

- std::vector<WebUIMessageHandler*>* handlers) const;

- virtual void GetDialogSize(gfx::Size* size) const;

- virtual std::string GetDialogArgs() const;

- virtual void OnDialogClosed(const std::string& json_retval);

- virtual void OnCloseContents(TabContents* source, bool* out_close_dialog);

- virtual std::wstring GetDialogTitle() const;

- virtual bool IsDialogModal() const;

- virtual bool ShouldShowDialogTitle() const;

- virtual bool HandleContextMenu(const ContextMenuParams& params);

+ std::vector<WebUIMessageHandler*>* handlers) const OVERRIDE;

+ virtual void GetDialogSize(gfx::Size* size) const OVERRIDE;

+ virtual std::string GetDialogArgs() const OVERRIDE;

+ virtual void OnDialogClosed(const std::string& json_retval) OVERRIDE;

+ virtual void OnCloseContents(TabContents* source, bool* out_close_dialog)

+ OVERRIDE;

+ virtual string16 GetDialogTitle() const OVERRIDE;

+ virtual bool IsDialogModal() const OVERRIDE;

+ virtual bool ShouldShowDialogTitle() const OVERRIDE;

+ virtual bool HandleContextMenu(const ContextMenuParams& params) OVERRIDE;

// GaiaAuthConsumer implementation.

virtual void OnClientLoginSuccess(