Fix a few lingering bugs in BrowserAccessibilityManager and BrowserAccessibilityCocoa.

content/browser/accessibility/browser_accessibility_cocoa.mm

Index: content/browser/accessibility/browser_accessibility_cocoa.mm
diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm
index b6b08ea2cbeb08e40b5e1f663b5defdee4223ecf..50720d17b07fd763fd854d551c1fc0b35e65ceb8 100644
--- a/content/browser/accessibility/browser_accessibility_cocoa.mm
+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm
@@ -16,6 +16,9 @@
 #include "grit/webkit_strings.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebRect.h"
 
+// TODO(dtseng): should this be forward declared here?
+extern "C" void NSAccessibilityUnregisterUniqueIdForUIElement(id element);

[Nico, 2011/08/02 22:07:14]

Is this SPI / a weak symbol? Can it resolve to NULL with future SDKs?

[David Tseng, 2011/08/03 00:13:22]

This is SPI from AppKit. There's no guarantee of its existence in future SDK's.
It's however also used in WebKit.

On 2011/08/02 22:07:14, Nico wrote:

[Nico, 2011/08/04 14:29:02]

Ok. Add a comment that says that this is SPI that's been tested to work on
10.5-10.7, file a radar to make this an API, dump the radar into
openradar.appspot.com, add the link to the comment, and give a short description
of what this function does.

+
 typedef WebAccessibility::IntAttribute IntAttribute;
 typedef WebAccessibility::StringAttribute StringAttribute;
 
@@ -247,6 +250,7 @@ NSDictionary* attributeToMethodNameMap = nil;
 // Deletes our associated BrowserAccessibilityMac.
 - (void)dealloc {
   if (browserAccessibility_) {
+    NSAccessibilityUnregisterUniqueIdForUIElement(self);
     delete browserAccessibility_;
     browserAccessibility_ = NULL;
   }
@@ -830,5 +834,9 @@ NSDictionary* attributeToMethodNameMap = nil;
   return browserAccessibility_->renderer_id();
 }
 
+- (BOOL)accessibilityShouldUseUniqueId {
+  return YES;
+}
+
 @end