Fix a few lingering bugs in BrowserAccessibilityManager and BrowserAccessibilityCocoa.

content/browser/accessibility/browser_accessibility_cocoa.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <execinfo.h>
 
 #import "content/browser/accessibility/browser_accessibility_cocoa.h"
 
 #include <map>
 
 #include "base/string16.h"
 #include "base/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "content/browser/accessibility/browser_accessibility_manager.h"
 #include "content/common/content_client.h"
 #include "grit/webkit_strings.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebRect.h"
 
+// TODO(dtseng): should this be forward declared here?
+extern "C" void NSAccessibilityUnregisterUniqueIdForUIElement(id element);

[Nico, 2011/08/02 22:07:14]

Is this SPI / a weak symbol? Can it resolve to NULL with future SDKs?

[David Tseng, 2011/08/03 00:13:22]

This is SPI from AppKit. There's no guarantee of its existence in future SDK's.
It's however also used in WebKit.

On 2011/08/02 22:07:14, Nico wrote:

[Nico, 2011/08/04 14:29:02]

Ok. Add a comment that says that this is SPI that's been tested to work on
10.5-10.7, file a radar to make this an API, dump the radar into
openradar.appspot.com, add the link to the comment, and give a short description
of what this function does.

+
 typedef WebAccessibility::IntAttribute IntAttribute;
 typedef WebAccessibility::StringAttribute StringAttribute;
 
 namespace {
 
 // Returns an autoreleased copy of the WebAccessibility's attribute.
 NSString* NSStringForStringAttribute(
     const std::map<StringAttribute, string16>& attributes,
     StringAttribute attribute) {
   std::map<StringAttribute, string16>::const_iterator iter =
@@ skipping 211 matching lines @@
   if ((self = [super init])) {
     browserAccessibility_ = accessibility;
     delegate_ = delegate;
   }
   return self;
 }
 
 // Deletes our associated BrowserAccessibilityMac.
 - (void)dealloc {
   if (browserAccessibility_) {
+    NSAccessibilityUnregisterUniqueIdForUIElement(self);
     delete browserAccessibility_;
     browserAccessibility_ = NULL;
   }
 
   [super dealloc];
 }
 
 // Returns an array of BrowserAccessibilityCocoa objects, representing the
 // accessibility children of this object.
 - (NSArray*)children {
@@ skipping 563 matching lines @@
   return ([self hash] == [object hash]);
 }
 
 - (NSUInteger)hash {
   // Potentially called during dealloc.
   if (!browserAccessibility_)
     return [super hash];
   return browserAccessibility_->renderer_id();
 }
 
+- (BOOL)accessibilityShouldUseUniqueId {
+  return YES;
+}
+
 @end