Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: views/controls/textfield/native_textfield_views.h

Issue 7461102: modification to RenderText for inheritance/SelectionModel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: fix a lint error Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/textfield/native_textfield_views.h
===================================================================
--- views/controls/textfield/native_textfield_views.h (revision 95245)
+++ views/controls/textfield/native_textfield_views.h (working copy)
@@ -122,6 +122,10 @@
virtual void ApplyDefaultStyle() OVERRIDE;
virtual void ClearEditHistory() OVERRIDE;
+ // TODO(xji): might need to declare it in NativeTextfieldWrapper.
msw 2011/08/03 19:46:39 I think we ought to inline this function at its on
+ // Selects the selection model given by |sel|.
+ void SelectSelectionModel(const gfx::SelectionModel& sel);
+
// ui::SimpleMenuModel::Delegate overrides
virtual bool IsCommandIdChecked(int command_id) const OVERRIDE;
virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE;
@@ -163,6 +167,14 @@
base::i18n::TextDirection direction) OVERRIDE;
virtual View* GetOwnerViewOfTextInputClient() OVERRIDE;
+ // TODO(xji): might need to declare in TextInputClient.
+ // Merge SelectionModels |start| and |end| so that selection start is
+ // the selection start from |start|, while selection end, caret position,
+ // and caret placement are values from |end|. Set the merged model.
+ // Returns false if the operation is not supported.
+ bool SetMergedSelectionModel(const gfx::SelectionModel& start,
msw 2011/08/03 19:46:39 I think we ought to inline this function at its on
+ const gfx::SelectionModel& end);
+
// Overridden from TextfieldViewsModel::Delegate:
virtual void OnCompositionTextConfirmedOrCleared() OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698