modification to RenderText for inheritance/SelectionModel

views/controls/textfield/native_textfield_views.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_VIEWS_H_
 #define VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_VIEWS_H_
 #pragma once
 
 #include "base/string16.h"
 #include "base/task.h"
@@ skipping 104 matching lines @@
   virtual size_t GetCursorPosition() const OVERRIDE;
   virtual bool HandleKeyPressed(const KeyEvent& e) OVERRIDE;
   virtual bool HandleKeyReleased(const KeyEvent& e) OVERRIDE;
   virtual void HandleFocus() OVERRIDE;
   virtual void HandleBlur() OVERRIDE;
   virtual TextInputClient* GetTextInputClient() OVERRIDE;
   virtual void ApplyStyleRange(const gfx::StyleRange& style) OVERRIDE;
   virtual void ApplyDefaultStyle() OVERRIDE;
   virtual void ClearEditHistory() OVERRIDE;
 
+  // TODO(xji): might need to declare it in NativeTextfieldWrapper.

[msw, 2011/08/03 19:46:39]

I think we ought to inline this function at its one use for now, and we can
expose it later if needed.

+  // Selects the selection model given by |sel|.
+  void SelectSelectionModel(const gfx::SelectionModel& sel);
+
   // ui::SimpleMenuModel::Delegate overrides
   virtual bool IsCommandIdChecked(int command_id) const OVERRIDE;
   virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE;
   virtual bool GetAcceleratorForCommandId(
       int command_id,
       ui::Accelerator* accelerator) OVERRIDE;
   virtual void ExecuteCommand(int command_id) OVERRIDE;
 
   // class name of internal
   static const char kViewClassName[];
@@ skipping 21 matching lines @@
   virtual bool SetSelectionRange(const ui::Range& range) OVERRIDE;
   virtual bool DeleteRange(const ui::Range& range) OVERRIDE;
   virtual bool GetTextFromRange(
       const ui::Range& range,
       const base::Callback<void(const string16&)>& callback) OVERRIDE;
   virtual void OnInputMethodChanged() OVERRIDE;
   virtual bool ChangeTextDirectionAndLayoutAlignment(
       base::i18n::TextDirection direction) OVERRIDE;
   virtual View* GetOwnerViewOfTextInputClient() OVERRIDE;
 
+  // TODO(xji): might need to declare in TextInputClient.
+  // Merge SelectionModels |start| and |end| so that selection start is
+  // the selection start from |start|, while selection end, caret position,
+  // and caret placement are values from |end|. Set the merged model.
+  // Returns false if the operation is not supported.
+  bool SetMergedSelectionModel(const gfx::SelectionModel& start,

[msw, 2011/08/03 19:46:39]

I think we ought to inline this function at its one use for now, and we can
expose it later if needed.

+                               const gfx::SelectionModel& end);
+
   // Overridden from TextfieldViewsModel::Delegate:
   virtual void OnCompositionTextConfirmedOrCleared() OVERRIDE;
 
   // Returns the TextfieldViewsModel's text/cursor/selection rendering model.
   gfx::RenderText* GetRenderText() const;
 
   // A callback function to periodically update the cursor state.
   void UpdateCursor();
 
   // Repaint the cursor.
@@ skipping 75 matching lines @@
   scoped_ptr<views::MenuItemView> context_menu_menu_;
 
   scoped_ptr<TouchSelectionController> touch_selection_controller_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeTextfieldViews);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_VIEWS_H_