Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Issue 7461098: Reland 87645 with clang fixes. (Closed)

Created:
9 years, 5 months ago by Nicolas Zea
Modified:
9 years, 5 months ago
Reviewers:
CC:
chromium-reviews, GeorgeY, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, Aaron Boodman, Paweł Hajdan Jr., Ilya Sherman, tim (not reviewing), dhollowa
Visibility:
Public.

Description

Reland 87645 with clang fixes. [Sync] Refactor sync datatype error handling. This introduces SyncError's, which are a convenient way of passing around an error location, type, and message. All datatypes have been refactored to use this, including in the AssociateModels code. A future change will use this to add support for continuing sync even when a datatype fails to start. In addition, eventually a future change will convert the UnrecoverableError handler to use SyncError's as well as have the datatype controller's and datatype manager surface SyncError's to the PSS. Original Review URL: http://codereview.chromium.org/7453014 TBR=akalin@chromium.org BUG=87645 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94204

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+786 lines, -273 lines) Patch
M chrome/browser/prefs/pref_model_associator.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/prefs/pref_model_associator.cc View 5 chunks +21 lines, -7 lines 0 comments Download
M chrome/browser/sync/api/sync_change_processor.h View 2 chunks +11 lines, -2 lines 0 comments Download
A chrome/browser/sync/api/sync_error.h View 1 1 chunk +79 lines, -0 lines 0 comments Download
A chrome/browser/sync/api/sync_error.cc View 1 1 chunk +92 lines, -0 lines 0 comments Download
A chrome/browser/sync/api/sync_error_unittest.cc View 1 chunk +114 lines, -0 lines 0 comments Download
M chrome/browser/sync/api/syncable_service.h View 3 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/sync/api/syncable_service_mock.h View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/sync/backend_migrator.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/sync/backend_migrator_unittest.cc View 1 chunk +18 lines, -8 lines 0 comments Download
M chrome/browser/sync/glue/app_model_associator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/app_model_associator.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/autofill_model_associator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_model_associator.cc View 7 chunks +13 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_model_associator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_model_associator.cc View 6 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 8 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager.h View 3 chunks +18 lines, -25 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager.cc View 1 chunk +38 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.cc View 10 chunks +39 lines, -21 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_mock.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/extension_model_associator.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/extension_model_associator.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller.cc View 5 chunks +13 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.cc View 6 chunks +52 lines, -26 lines 0 comments Download
M chrome/browser/sync/glue/model_associator.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/model_associator_mock.h View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.cc View 5 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/password_model_associator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_model_associator.cc View 9 chunks +21 lines, -10 lines 0 comments Download
M chrome/browser/sync/glue/preference_data_type_controller_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 5 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/syncable_service_adapter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/syncable_service_adapter.cc View 1 chunk +14 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/theme_model_associator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/theme_model_associator.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.cc View 9 chunks +21 lines, -10 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 2 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/syncable/model_type_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698