Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc

Issue 7461098: Reland 87645 with clang fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
index d385e76c7a0a517be39c6d9fd6dc4378502b89b6..0c4bce05b80d95661d5581cfa7cbe34579ed19de 100644
--- a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
+++ b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
@@ -74,14 +74,14 @@ class BookmarkDataTypeControllerTest : public testing::Test {
EXPECT_CALL(*profile_sync_factory_, CreateBookmarkSyncComponents(_, _));
EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)).
WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true)));
- EXPECT_CALL(*model_associator_, AssociateModels()).
+ EXPECT_CALL(*model_associator_, AssociateModels(_)).
WillRepeatedly(Return(true));
EXPECT_CALL(service_, ActivateDataType(_, _));
}
void SetStopExpectations() {
EXPECT_CALL(service_, DeactivateDataType(_, _));
- EXPECT_CALL(*model_associator_, DisassociateModels());
+ EXPECT_CALL(*model_associator_, DisassociateModels(_));
}
MessageLoopForUI message_loop_;
@@ -160,8 +160,9 @@ TEST_F(BookmarkDataTypeControllerTest, StartAssociationFailed) {
WillRepeatedly(Return(true));
EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)).
WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true)));
- EXPECT_CALL(*model_associator_, AssociateModels()).
- WillRepeatedly(Return(false));
+ EXPECT_CALL(*model_associator_, AssociateModels(_)).
+ WillRepeatedly(DoAll(browser_sync::SetSyncError(syncable::BOOKMARKS),
+ Return(false)));
EXPECT_CALL(start_callback_, Run(DataTypeController::ASSOCIATION_FAILED, _));
bookmark_dtc_->Start(NewCallback(&start_callback_, &StartCallback::Run));
« no previous file with comments | « chrome/browser/sync/glue/autofill_profile_model_associator.cc ('k') | chrome/browser/sync/glue/bookmark_model_associator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698