Web Intents: Preparatory work.

chrome/browser/intents/register_intent_handler_infobar_delegate.cc

Index: chrome/browser/intents/register_intent_handler_infobar_delegate.cc
diff --git a/chrome/browser/intents/register_intent_handler_infobar_delegate.cc b/chrome/browser/intents/register_intent_handler_infobar_delegate.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f6d91e6f23c999f5906682ad00c01b580379cb20
--- /dev/null
+++ b/chrome/browser/intents/register_intent_handler_infobar_delegate.cc
@@ -0,0 +1,60 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/intents/register_intent_handler_infobar_delegate.h"
+
+#include "base/utf_string_conversions.h"
+#include "chrome/common/url_constants.h"
+#include "content/browser/tab_contents/tab_contents.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+
+RegisterIntentHandlerInfoBarDelegate::RegisterIntentHandlerInfoBarDelegate(
+    TabContents* tab_contents)
+    : ConfirmInfoBarDelegate(tab_contents),
+      tab_contents_(tab_contents) {
+}
+
+InfoBarDelegate::Type
+RegisterIntentHandlerInfoBarDelegate::GetInfoBarType() const {

[Peter Kasting, 2011/07/26 22:08:32]

Nit: Indent 4

[James Hawkins, 2011/07/26 22:35:39]

Done. Perhaps this should be added to the style guide, as it's not included and
seems strange at first.

+  return PAGE_ACTION_TYPE;
+}
+
+string16 RegisterIntentHandlerInfoBarDelegate::GetMessageText() const {
+  return l10n_util::GetStringFUTF16(IDS_REGISTER_PROTOCOL_HANDLER_CONFIRM,
+                                    string16(), string16());
+}
+
+int RegisterIntentHandlerInfoBarDelegate::GetButtons() const {
+  return BUTTON_OK | BUTTON_CANCEL | BUTTON_NONE;

[Peter Kasting, 2011/07/26 22:08:32]

This doesn't work.  BUTTON_NONE is zero, not a separate button.  You cannot
create three-button infobars by default.

Have you gone over what you want with a UI designer?  I'm already uncomfortable
with how many infobars we have, and adding a new one with three buttons raises
my red flags.  Perhaps there's a better UI for this.  For example, at least
trimming to 2 buttons by making "No" mean "Never" and removing the "Never"
button.  Maybe the UI folks could also help you find a clearer way of expressing
the question than "handle intents", which is a phrase that doesn't mean anything
to me, let alone the rest of our users.

[James Hawkins, 2011/07/26 22:35:39]

There's an open question in the design doc about using 'No' as 'Never', which is
probably the best solution here.  There's also an open question about the
string, which is crappy for now, but can be fixed after commit. Rapid
prototyping!

To answer your question about using an infobar at all, I spoke with a few UI
leads earlier, and this ties into the brainstorming happening now surrounding
better permissions UI, which doesn't have a solution yet. Using an infobar
matches registerProtocolHandler and geolocation requests, which are both similar
features to Web Intents wrt permissions.

+}
+
+string16 RegisterIntentHandlerInfoBarDelegate::GetButtonLabel(
+    InfoBarButton button) const {
+  switch (button) {
+    case BUTTON_OK:
+      return l10n_util::GetStringUTF16(IDS_REGISTER_INTENT_HANDLER_ACCEPT);
+    case BUTTON_CANCEL:
+      return l10n_util::GetStringFUTF16(IDS_REGISTER_INTENT_HANDLER_DENY,
+                                        string16());
+    case BUTTON_NONE:
+      return l10n_util::GetStringFUTF16(IDS_REGISTER_INTENT_HANDLER_NEVER,
+                                        string16());
+  }
+
+  NOTREACHED();
+  return string16();
+}
+
+string16 RegisterIntentHandlerInfoBarDelegate::GetLinkText() const {
+  return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
+}
+
+bool RegisterIntentHandlerInfoBarDelegate::LinkClicked(
+    WindowOpenDisposition disposition) {
+  // TODO(jhawkins): Open the Web Intents Help Center article once it is
+  // written.
+  // TODO(jhawkins): Add associated bug for the article here.
+  return false;
+}