Web Intents: Preparatory work.

chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc

Index: chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc
diff --git a/chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc b/chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..cd6fff44e4b95ae4d3798eff0a8bebaddbdcee13
--- /dev/null
+++ b/chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc
@@ -0,0 +1,36 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/intents/register_intent_handler_infobar_delegate.h"
+#include "chrome/browser/tab_contents/infobar_delegate.h"
+#include "grit/generated_resources.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/l10n/l10n_util.h"
+
+TEST(RegisterIntentHandlerInfoBarDelegateTest, GetInfoBarType) {

[Peter Kasting, 2011/07/26 22:08:32]

None of these tests is useful.  Just kill this file.

[James Hawkins, 2011/07/26 22:35:39]

The tests under the TODOs are important (which they'll be possible once
http://codereview.chromium.org/7461089/ lands), and the other tests are not
necessarily bad.  Are you insisting I remove them?  I'd really prefer to keep
them.

[Peter Kasting, 2011/07/26 22:52:12]

Tests that verify at such a low level -- e.g. "yes, my infobar contains two
buttons" -- aren't ever going to catch real mistakes, they just end up making
refactoring more frustrating.  I've already had to kill some Mac tests that ran
at this level because they made all the reworking I've been doing hellish for no
benefit.

Testing that your strings are the strings you put in the string table is
similarly pointless.  I can't speak as much for what you've TODOd because I
don't know precisely what you're planning on testing, but at least what you have
here right now is all stuff that I would prefer to see gone because I think it's
cost with no benefit.

+  RegisterIntentHandlerInfoBarDelegate delegate(NULL);
+  EXPECT_EQ(InfoBarDelegate::PAGE_ACTION_TYPE, delegate.GetInfoBarType());
+}
+
+// TODO(jhawkins): GetMessageText once WebIntentData is passed into the
+// constructor.
+
+TEST(RegisterIntentHandlerInfoBarDelegateTest, GetButtons) {
+  RegisterIntentHandlerInfoBarDelegate delegate(NULL);
+  const int kExpectedButtons = ConfirmInfoBarDelegate::BUTTON_OK |
+                               ConfirmInfoBarDelegate::BUTTON_CANCEL |
+                               ConfirmInfoBarDelegate::BUTTON_NONE;
+  EXPECT_EQ(kExpectedButtons, delegate.GetButtons());
+}
+
+// TODO(jhawkins): GetButtonLabel once WebIntentData is passed into the
+// constructor.
+
+TEST(RegisterIntentHandlerInfoBarDelegateTest, GetLinkText) {
+  RegisterIntentHandlerInfoBarDelegate delegate(NULL);
+  EXPECT_EQ(l10n_util::GetStringUTF16(IDS_LEARN_MORE), delegate.GetLinkText());
+}
+
+// TODO(jhawkins): LinkClicked once WebIntentRegistry is hooked up and saving
+// data.