Improve layout for bookmark-apps. Add a treatment for small icons.

chrome/browser/extensions/extensions_ui.cc

Index: chrome/browser/extensions/extensions_ui.cc
diff --git a/chrome/browser/extensions/extensions_ui.cc b/chrome/browser/extensions/extensions_ui.cc
index 8eb68c83407ca062febc878a8f377ad46de023b8..04769caa651bc4cdfa010dda30771eaa09ace432 100644
--- a/chrome/browser/extensions/extensions_ui.cc
+++ b/chrome/browser/extensions/extensions_ui.cc
@@ -639,11 +639,12 @@ DictionaryValue* ExtensionsDOMHandler::CreateExtensionDetailValue(
     ExtensionService* service, const Extension* extension,
     const std::vector<ExtensionPage>& pages, bool enabled, bool terminated) {
   DictionaryValue* extension_data = new DictionaryValue();
+  bool icon_exists = true;
   GURL icon =
       ExtensionIconSource::GetIconURL(extension,
                                       Extension::EXTENSION_ICON_MEDIUM,
                                       ExtensionIconSet::MATCH_BIGGER,
-                                      !enabled);
+                                      !enabled, &icon_exists);
   extension_data->SetString("id", extension->id());
   extension_data->SetString("name", extension->name());
   extension_data->SetString("description", extension->description());
@@ -651,6 +652,7 @@ DictionaryValue* ExtensionsDOMHandler::CreateExtensionDetailValue(
     extension_data->SetString("path", extension->path().value());
   extension_data->SetString("version", extension->version()->GetString());
   extension_data->SetString("icon", icon.spec());
+  extension_data->SetBoolean("icon_exists", icon_exists);

[Evan Stade, 2011/07/27 16:31:45]

this is unused, right? Why set it?

[Greg Billock, 2011/07/27 19:52:24]

I changed line 647 to the new signature. I thought the extension manager is
likely to want this, so put it in. I could just pass NULL though...

[Evan Stade, 2011/07/27 23:04:31]

I would just pass NULL for now instead of adding code that doesn't do anything.
You can file a bug if you think that the extension manager should use it
somehow.

[Greg Billock, 2011/07/28 16:59:59]

Nah, showing the default 'huh?' icon is probably fine here.

On 2011/07/27 23:04:31, Evan Stade wrote:

   extension_data->SetBoolean("isUnpacked",
                              extension->location() == Extension::LOAD);
   extension_data->SetBoolean("mayDisable",