Improve layout for bookmark-apps. Add a treatment for small icons.

chrome/browser/extensions/extensions_ui.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extensions_ui.h"
 
 #include <algorithm>
 
 #include "base/base64.h"
 #include "base/callback.h"
@@ skipping 621 matching lines @@
     HandleRequestExtensionsData(NULL);
   }
   deleting_rvh_ = NULL;
 }
 
 // Static
 DictionaryValue* ExtensionsDOMHandler::CreateExtensionDetailValue(
     ExtensionService* service, const Extension* extension,
     const std::vector<ExtensionPage>& pages, bool enabled, bool terminated) {
   DictionaryValue* extension_data = new DictionaryValue();
+  bool icon_exists = true;
   GURL icon =
       ExtensionIconSource::GetIconURL(extension,
                                       Extension::EXTENSION_ICON_MEDIUM,
                                       ExtensionIconSet::MATCH_BIGGER,
-                                      !enabled);
+                                      !enabled, &icon_exists);
   extension_data->SetString("id", extension->id());
   extension_data->SetString("name", extension->name());
   extension_data->SetString("description", extension->description());
   if (extension->location() == Extension::LOAD)
     extension_data->SetString("path", extension->path().value());
   extension_data->SetString("version", extension->version()->GetString());
   extension_data->SetString("icon", icon.spec());
+  extension_data->SetBoolean("icon_exists", icon_exists);

[Evan Stade, 2011/07/27 16:31:45]

this is unused, right? Why set it?

[Greg Billock, 2011/07/27 19:52:24]

I changed line 647 to the new signature. I thought the extension manager is
likely to want this, so put it in. I could just pass NULL though...

[Evan Stade, 2011/07/27 23:04:31]

I would just pass NULL for now instead of adding code that doesn't do anything.
You can file a bug if you think that the extension manager should use it
somehow.

[Greg Billock, 2011/07/28 16:59:59]

Nah, showing the default 'huh?' icon is probably fine here.

On 2011/07/27 23:04:31, Evan Stade wrote:

   extension_data->SetBoolean("isUnpacked",
                              extension->location() == Extension::LOAD);
   extension_data->SetBoolean("mayDisable",
                              Extension::UserMayDisable(extension->location()));
   extension_data->SetBoolean("enabled", enabled);
   extension_data->SetBoolean("terminated", terminated);
   extension_data->SetBoolean("enabledIncognito",
       service ? service->IsIncognitoEnabled(extension->id()) : false);
   extension_data->SetBoolean("wantsFileAccess", extension->wants_file_access());
   extension_data->SetBoolean("allowFileAccess",
@@ skipping 130 matching lines @@
   return ResourceBundle::GetSharedInstance().
       LoadDataResourceBytes(IDR_PLUGIN);
 }
 
 // static
 void ExtensionsUI::RegisterUserPrefs(PrefService* prefs) {
   prefs->RegisterBooleanPref(prefs::kExtensionsUIDeveloperMode,
                              false,
                              PrefService::SYNCABLE_PREF);
 }