Vboot Reference: Make length types explicitly sized.

Vboot Reference: Make length types explicitly sized.

[Chris Masone, 2010-03-11 02:30:44]

if these are all OK, LGTM

http://codereview.chromium.org/744002/diff/1/21
File src/platform/vboot_reference/utils/firmware_image.c (right):

http://codereview.chromium.org/744002/diff/1/21#newcode54
src/platform/vboot_reference/utils/firmware_image.c:54: int signature_len;
what about the above?  Are they all ok to be < 64 bits?

http://codereview.chromium.org/744002/diff/1/26
File src/platform/vboot_reference/utils/signature_digest_utility.c (right):

http://codereview.chromium.org/744002/diff/1/26#newcode25
src/platform/vboot_reference/utils/signature_digest_utility.c:25: uint32_t
signature_digest_len;
missed this one?

[gauravsh, 2010-03-11 02:33:39]

The ones you pointed out are all safe to be 32-bits and are always bounded.
Submitting.

http://codereview.chromium.org/744002/diff/1/21
File src/platform/vboot_reference/utils/firmware_image.c (right):

http://codereview.chromium.org/744002/diff/1/21#newcode54
src/platform/vboot_reference/utils/firmware_image.c:54: int signature_len;
On 2010/03/11 02:30:46, cmasone wrote:
> what about the above?  Are they all ok to be < 64 bits?
Yes, these are always going to be bounded.

http://codereview.chromium.org/744002/diff/1/26
File src/platform/vboot_reference/utils/signature_digest_utility.c (right):

http://codereview.chromium.org/744002/diff/1/26#newcode25
src/platform/vboot_reference/utils/signature_digest_utility.c:25: uint32_t
signature_digest_len;
On 2010/03/11 02:30:46, cmasone wrote:
> missed this one?
This will be bounded too (it's calculated from the constant maps below).