Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: src/platform/vboot_reference/utils/firmware_image.c

Issue 744002: Vboot Reference: Make length types explicitly sized. (Closed)
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/platform/vboot_reference/utils/firmware_image.c
diff --git a/src/platform/vboot_reference/utils/firmware_image.c b/src/platform/vboot_reference/utils/firmware_image.c
index c5838ffaed556dc5d172343bdc0d082bfdd9d019..c0a660bc8d08e28e3070a296be0094e3b3cc1db4 100644
--- a/src/platform/vboot_reference/utils/firmware_image.c
+++ b/src/platform/vboot_reference/utils/firmware_image.c
@@ -47,7 +47,7 @@ void FirmwareImageFree(FirmwareImage* image) {
}
FirmwareImage* ReadFirmwareImage(const char* input_file) {
- uint32_t file_size;
+ uint64_t file_size;
int image_len = 0; /* Total size of the firmware image. */
int header_len = 0;
int firmware_sign_key_len;
@@ -188,7 +188,7 @@ uint8_t* GetFirmwarePreambleBlob(const FirmwareImage* image) {
}
-uint8_t* GetFirmwareBlob(const FirmwareImage* image, int* blob_len) {
+uint8_t* GetFirmwareBlob(const FirmwareImage* image, uint64_t* blob_len) {
int firmware_signature_len;
uint8_t* firmware_blob = NULL;
uint8_t* header_blob = NULL;
@@ -235,7 +235,7 @@ int WriteFirmwareImage(const char* input_file,
const FirmwareImage* image) {
int fd;
uint8_t* firmware_blob;
- int blob_len;
+ uint64_t blob_len;
if (!image)
return 0;
@@ -276,7 +276,7 @@ void PrintFirmwareImage(const FirmwareImage* image) {
/* TODO(gauravsh): Output hash and key signature here? */
/* Print preamble. */
printf("Firmware Version = %d\n"
- "Firmware Length = %d\n\n",
+ "Firmware Length = %" PRIu64 "\n\n",
image->firmware_version,
image->firmware_len);
/* Output key signature here? */

Powered by Google App Engine
This is Rietveld 408576698