Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1807)

Issue 7439008: Remove "--logfile=*" from V8 flags in renderers. It is no more needed and is ignored by V8. (Closed)

Created:
9 years, 5 months ago by mnaganov (inactive)
Modified:
9 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam
Visibility:
Public.

Description

Remove "--logfile=*" from V8 flags in renderers. It is no more needed and is ignored by V8. R=pfeldman@chromium.org,jamesr@chromium.org BUG=v8/859 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/render_process_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mnaganov (inactive)
9 years, 5 months ago (2011-07-19 19:14:19 UTC) #1
mnaganov (inactive)
Pavel, can you please take a look? Soeren is on vacation.
9 years, 5 months ago (2011-07-20 12:55:07 UTC) #2
pfeldman
LGTM
9 years, 5 months ago (2011-07-20 15:10:54 UTC) #3
mnaganov (inactive)
Hi James, I need your approval for this change. This is just a cleanup.
9 years, 5 months ago (2011-07-20 15:16:56 UTC) #4
jamesr
9 years, 5 months ago (2011-07-21 16:18:16 UTC) #5
lgtm

sorry for the delay, I missed the original email.

Powered by Google App Engine
This is Rietveld 408576698