Uploading for backup...

Uploading for backup...


BUG=
TEST=

[John Knottenbelt, 2011-07-19 09:34:00]

Hi Satoru,

I realise that this CL isn't ready for review yet, but I wanted to ask you about
the dbus_bus_get call and whether it was thread safe - see inside for the exact
question :)

Cheers

John

http://codereview.chromium.org/7413004/diff/5001/net/dbus/dbus.cc
File net/dbus/dbus.cc (right):

http://codereview.chromium.org/7413004/diff/5001/net/dbus/dbus.cc#newcode34
net/dbus/dbus.cc:34: connection_ = dbus_bus_get(static_cast<DBusBusType>(type_),
&error);
Reading the docs for bus, this will return an existing connection if present.
Will this be OK to access from multiple threads? There is also a
dbus_bus_get_private API that might be better for multiple threads to manage
their own connections.

[satorux1, 2011-07-19 16:45:03]

Thank you for the feedback!

http://codereview.chromium.org/7413004/diff/5001/net/dbus/dbus.cc
File net/dbus/dbus.cc (right):

http://codereview.chromium.org/7413004/diff/5001/net/dbus/dbus.cc#newcode34
net/dbus/dbus.cc:34: connection_ = dbus_bus_get(static_cast<DBusBusType>(type_),
&error);
On 2011/07/19 09:34:01, John Knottenbelt wrote:
> Reading the docs for bus, this will return an existing connection if present.
> Will this be OK to access from multiple threads? There is also a
> dbus_bus_get_private API that might be better for multiple threads to manage
> their own connections.

That's a good point. I'm going to provide an option to create a private
connection. Alternatively, it make make more sense to always provide a private
connection. I'll think about it later.

[satorux1, 2011-07-20 00:08:59]

Uploading today's work for backup. Not yet still ready for a code review.

http://codereview.chromium.org/7413004/diff/10001/net/dbus/dbus.h
File net/dbus/dbus.h (right):

http://codereview.chromium.org/7413004/diff/10001/net/dbus/dbus.h#newcode42
net/dbus/dbus.h:42: PRIVATE,
John, the patch is still far from code-review-ready, but just added PRIVATE
option per your suggestion.