Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 7398033: Revert 92885 - Completed the implementation for PPB_Graphics3D interface. (Closed)

Created:
9 years, 5 months ago by alokp
Modified:
9 years, 5 months ago
Reviewers:
alokp
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 92885 - Completed the implementation for PPB_Graphics3D interface. - Mostly copied from the implementations for PPB_Surface3D and PPB_Context3D. - Added the proxy implementation - Refactored common code between host and plugin side into a common class. I will send the changes to bind Graphics3D with Instance and OpenGLES2 interface in a separate patch. BUG=86370, 78087 Review URL: http://codereview.chromium.org/6824006 TBR=alokp@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1514 lines) Patch
D ppapi/c/dev/ppb_graphics_3d_trusted_dev.h View 1 chunk +0 lines, -104 lines 0 comments Download
M ppapi/ppapi_cpp.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 3 chunks +0 lines, -4 lines 0 comments Download
M ppapi/proxy/interface_id.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/plugin_resource.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_messages.h View 2 chunks +0 lines, -49 lines 0 comments Download
D ppapi/proxy/ppb_graphics_3d_proxy.h View 1 chunk +0 lines, -125 lines 0 comments Download
D ppapi/proxy/ppb_graphics_3d_proxy.cc View 1 chunk +0 lines, -612 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 2 chunks +1 line, -12 lines 0 comments Download
M ppapi/shared_impl/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/shared_impl/graphics_3d_impl.h View 1 chunk +0 lines, -63 lines 0 comments Download
D ppapi/shared_impl/graphics_3d_impl.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M ppapi/tests/all_c_includes.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/thunk/ppb_graphics_3d_api.h View 2 chunks +0 lines, -20 lines 0 comments Download
D ppapi/thunk/ppb_graphics_3d_trusted_thunk.cc View 1 chunk +0 lines, -125 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.h View 3 chunks +8 lines, -59 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.cc View 2 chunks +20 lines, -209 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
alokp
9 years, 5 months ago (2011-07-18 21:18:19 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698