Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6149)

Unified Diff: chrome/common/nacl_types.h

Issue 7395024: For Linux, create a ZygoteForkDelegate that uses the nacl_helper executable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: A zygote fork delegate for Native Client Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/nacl_types.h
diff --git a/chrome/common/nacl_types.h b/chrome/common/nacl_types.h
index b61d9eff925e2a72b8c5e8c00bee024fbb3d03e4..3d77e2f706f41e508e8c333039861cf85859bd8d 100644
--- a/chrome/common/nacl_types.h
+++ b/chrome/common/nacl_types.h
@@ -7,6 +7,7 @@
#define CHROME_COMMON_NACL_TYPES_H_
#pragma once
+#include "base/native_library.h" // for HANDLE and OS_POSIX
agl 2011/07/18 21:19:35 I think this should be removed. Unless the types a
Brad Chen 2011/07/18 22:40:29 Just to double check: given that HANDLE and OS_POS
agl 2011/07/18 22:56:35 #include "build/build_config.h" for OS_* defines.
Brad Chen 2011/07/18 23:05:48 Done.
#if defined(OS_POSIX)
#include "base/file_descriptor_posix.h"
#endif
@@ -19,7 +20,8 @@ namespace nacl {
inline HANDLE ToNativeHandle(const FileDescriptor& desc) {
return reinterpret_cast<HANDLE>(desc);
}
-#elif defined(OS_POSIX)
+#endif
agl 2011/07/18 21:19:35 I don't believe that we have any platforms where O
Brad Chen 2011/07/18 22:40:29 Done.
+#if defined(OS_POSIX)
typedef base::FileDescriptor FileDescriptor;
inline int ToNativeHandle(const FileDescriptor& desc) {
return desc.fd;

Powered by Google App Engine
This is Rietveld 408576698