For Linux, create a ZygoteForkDelegate that uses the nacl_helper executable

chrome/common/nacl_types.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Handle passing definitions for NaCl
 #ifndef CHROME_COMMON_NACL_TYPES_H_
 #define CHROME_COMMON_NACL_TYPES_H_
 #pragma once
 
+#include "base/native_library.h"  // for HANDLE and OS_POSIX

[agl, 2011/07/18 21:19:35]

I think this should be removed. Unless the types are used in the header file
itself, the header can be included in .cc files.

[Brad Chen, 2011/07/18 22:40:29]

Just to double check: given that HANDLE and OS_POSIX are used in this file I
would have thought the include belongs in this file.

On 2011/07/18 21:19:35, agl wrote:

[agl, 2011/07/18 22:56:35]

#include "build/build_config.h" for OS_* defines.

#if defined(OS_WIN)
#include <windows.h>
#endif

for HANDLE.

[Brad Chen, 2011/07/18 23:05:48]

Done.

 #if defined(OS_POSIX)
 #include "base/file_descriptor_posix.h"
 #endif
 
 // TODO(gregoryd): add a Windows definition for base::FileDescriptor
 namespace nacl {
 #if defined(OS_WIN)
   // We assume that HANDLE always uses less than 32 bits
   typedef int FileDescriptor;
   inline HANDLE ToNativeHandle(const FileDescriptor& desc) {
     return reinterpret_cast<HANDLE>(desc);
   }
-#elif defined(OS_POSIX)
+#endif

[agl, 2011/07/18 21:19:35]

I don't believe that we have any platforms where OS_WIN and OS_POSIX are both
true, so the previous #elif was correct.

[Brad Chen, 2011/07/18 22:40:29]

Done.

+#if defined(OS_POSIX)
   typedef base::FileDescriptor FileDescriptor;
   inline int ToNativeHandle(const FileDescriptor& desc) {
     return desc.fd;
   }
 #endif
 }
 
 #endif  // CHROME_COMMON_NACL_TYPES_H_