Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: ppapi/thunk/ppb_video_decoder_thunk.cc

Issue 7361010: Enable fire-and-forget Destroy of HW video decoder, and misc other improvements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: vrk CR responses. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/thunk/ppb_video_decoder_api.h ('k') | webkit/plugins/ppapi/plugin_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/thunk/ppb_video_decoder_thunk.cc
diff --git a/ppapi/thunk/ppb_video_decoder_thunk.cc b/ppapi/thunk/ppb_video_decoder_thunk.cc
index 434d804fc2521e1419106f871963b9f0c9badd34..996eccaf30bf310209bb0a0bcabc03f7d179e400 100644
--- a/ppapi/thunk/ppb_video_decoder_thunk.cc
+++ b/ppapi/thunk/ppb_video_decoder_thunk.cc
@@ -81,13 +81,11 @@ int32_t Reset(PP_Resource video_decoder,
return MayForceCallback(callback, result);
}
-int32_t Destroy(PP_Resource video_decoder,
- PP_CompletionCallback callback) {
+void Destroy(PP_Resource video_decoder) {
EnterVideoDecoder enter(video_decoder, true);
if (enter.failed())
brettw 2011/07/15 16:57:21 In this case I would do: if (enter.succeeded())
Ami GONE FROM CHROMIUM 2011/07/15 17:10:15 Done.
- return MayForceCallback(callback, PP_ERROR_BADRESOURCE);
- int32_t result = enter.object()->Destroy(callback);
- return MayForceCallback(callback, result);
+ return;
+ enter.object()->Destroy();
}
const PPB_VideoDecoder_Dev g_ppb_videodecoder_thunk = {
« no previous file with comments | « ppapi/thunk/ppb_video_decoder_api.h ('k') | webkit/plugins/ppapi/plugin_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698