Enable fire-and-forget Destroy of HW video decoder, and misc other improvements.

ppapi/thunk/ppb_video_decoder_thunk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/thunk/common.h"
 #include "ppapi/thunk/enter.h"
 #include "ppapi/thunk/thunk.h"
 #include "ppapi/thunk/ppb_video_decoder_api.h"
 #include "ppapi/thunk/resource_creation_api.h"
@@ skipping 63 matching lines @@
 
 int32_t Reset(PP_Resource video_decoder,
               PP_CompletionCallback callback) {
   EnterVideoDecoder enter(video_decoder, true);
   if (enter.failed())
     return MayForceCallback(callback, PP_ERROR_BADRESOURCE);
   int32_t result = enter.object()->Reset(callback);
   return MayForceCallback(callback, result);
 }
 
-int32_t Destroy(PP_Resource video_decoder,
-                PP_CompletionCallback callback) {
+void Destroy(PP_Resource video_decoder) {
   EnterVideoDecoder enter(video_decoder, true);
   if (enter.failed())

[brettw, 2011/07/15 16:57:21]

In this case I would do:
  if (enter.succeeded())
    enter.object()->Destroy();
To save a line.

[Ami GONE FROM CHROMIUM, 2011/07/15 17:10:15]

Done.

-    return MayForceCallback(callback, PP_ERROR_BADRESOURCE);
-  int32_t result = enter.object()->Destroy(callback);
-  return MayForceCallback(callback, result);
+    return;
+  enter.object()->Destroy();
 }
 
 const PPB_VideoDecoder_Dev g_ppb_videodecoder_thunk = {
   &Create,
   &IsVideoDecoder,
   &Initialize,
   &Decode,
   &AssignGLESBuffers,
   &ReusePictureBuffer,
   &Flush,
   &Reset,
   &Destroy
 };
 
 }  // namespace
 
 const PPB_VideoDecoder_Dev* GetPPB_VideoDecoder_Thunk() {
   return &g_ppb_videodecoder_thunk;
 }
 
 }  // namespace thunk
 }  // namespace ppapi