Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: content/renderer/gpu/gpu_video_decode_accelerator_host.cc

Issue 7361010: Enable fire-and-forget Destroy of HW video decoder, and misc other improvements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: vrk CR responses. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/gpu_video_decode_accelerator_host.cc
diff --git a/content/renderer/gpu/gpu_video_decode_accelerator_host.cc b/content/renderer/gpu/gpu_video_decode_accelerator_host.cc
index 7c2576b88af3018426fee1c5a3d89d32a2371ad3..91d88a1653600a26d8fc8a222af5d764e7e15666 100644
--- a/content/renderer/gpu/gpu_video_decode_accelerator_host.cc
+++ b/content/renderer/gpu/gpu_video_decode_accelerator_host.cc
@@ -59,8 +59,6 @@ bool GpuVideoDecodeAcceleratorHost::OnMessageReceived(const IPC::Message& msg) {
OnFlushDone)
IPC_MESSAGE_HANDLER(AcceleratedVideoDecoderHostMsg_ResetDone,
OnResetDone)
- IPC_MESSAGE_HANDLER(AcceleratedVideoDecoderHostMsg_DestroyDone,
- OnDestroyDone)
IPC_MESSAGE_HANDLER(AcceleratedVideoDecoderHostMsg_EndOfStream,
OnEndOfStream)
IPC_MESSAGE_HANDLER(AcceleratedVideoDecoderHostMsg_ErrorNotification,
@@ -137,12 +135,8 @@ void GpuVideoDecodeAcceleratorHost::Flush() {
void GpuVideoDecodeAcceleratorHost::Reset() {
DCHECK(CalledOnValidThread());
- if (!ipc_sender_->Send(new AcceleratedVideoDecoderMsg_Reset(
- command_buffer_route_id_, SyncTokens()))) {
- LOG(ERROR) << "Send(AcceleratedVideoDecoderMsg_Reset) failed";
- // TODO(fischman/vrk): signal error to client.
- return;
- }
+ Send(new AcceleratedVideoDecoderMsg_Reset(
+ command_buffer_route_id_, SyncTokens()));
}
void GpuVideoDecodeAcceleratorHost::Destroy() {
@@ -209,11 +203,6 @@ void GpuVideoDecodeAcceleratorHost::OnResetDone() {
client_->NotifyResetDone();
}
-void GpuVideoDecodeAcceleratorHost::OnDestroyDone() {
- DCHECK(CalledOnValidThread());
- client_->NotifyDestroyDone();
-}
-
void GpuVideoDecodeAcceleratorHost::OnEndOfStream() {
DCHECK(CalledOnValidThread());
client_->NotifyEndOfStream();

Powered by Google App Engine
This is Rietveld 408576698