Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: content/renderer/gpu/command_buffer_proxy.h

Issue 7361010: Enable fire-and-forget Destroy of HW video decoder, and misc other improvements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: vrk CR responses. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/command_buffer_proxy.h
diff --git a/content/renderer/gpu/command_buffer_proxy.h b/content/renderer/gpu/command_buffer_proxy.h
index 9879169c3046aab84e46784cc1c39c0d909ec4b8..aba15c9305a32041dbeb3a1cdf956e00c037694b 100644
--- a/content/renderer/gpu/command_buffer_proxy.h
+++ b/content/renderer/gpu/command_buffer_proxy.h
@@ -83,14 +83,12 @@ class CommandBufferProxy : public gpu::CommandBuffer,
void SetNotifyRepaintTask(Task* task);
// Sends an IPC message to create a GpuVideoDecodeAccelerator. Creates and
- // returns a pointer to a GpuVideoDecodeAcceleratorHost. CommandBufferProxy
- // owns the GpuVideoDecodeAcceleratorHost and does not transfer ownership to
- // the caller of this method.
+ // returns a pointer to a GpuVideoDecodeAcceleratorHost.
// Returns NULL on failure to create the GpuVideoDecodeAcceleratorHost.
// Note that the GpuVideoDecodeAccelerator may still fail to be created in
// the GPU process, even if this returns non-NULL. In this case the client is
// notified of an error later.
- GpuVideoDecodeAcceleratorHost* CreateVideoDecoder(
+ scoped_refptr<GpuVideoDecodeAcceleratorHost> CreateVideoDecoder(
const std::vector<uint32>& configs,
gpu::CommandBufferHelper* cmd_buffer_helper,
media::VideoDecodeAccelerator::Client* client);
@@ -126,7 +124,7 @@ class CommandBufferProxy : public gpu::CommandBuffer,
// The video decoder host corresponding to the stub's video decoder in the GPU
// process, if one exists.
- scoped_ptr<GpuVideoDecodeAcceleratorHost> video_decoder_host_;
+ scoped_refptr<GpuVideoDecodeAcceleratorHost> video_decoder_host_;
// The last cached state received from the service.
State last_state_;

Powered by Google App Engine
This is Rietveld 408576698