Chromium Code Reviews| Index: ppapi/c/dev/ppb_video_decoder_dev.h |
| diff --git a/ppapi/c/dev/ppb_video_decoder_dev.h b/ppapi/c/dev/ppb_video_decoder_dev.h |
| index 6564521b1ebb1523ff5af7a0f1e9923fa27b7087..5c762eb19abb17d380d2162eab12a37a5fd0ea8a 100644 |
| --- a/ppapi/c/dev/ppb_video_decoder_dev.h |
| +++ b/ppapi/c/dev/ppb_video_decoder_dev.h |
| @@ -9,15 +9,14 @@ |
| #include "ppapi/c/pp_completion_callback.h" |
| #include "ppapi/c/pp_var.h" |
| -#define PPB_VIDEODECODER_DEV_INTERFACE_0_11 "PPB_VideoDecoder(Dev);0.11" |
| -#define PPB_VIDEODECODER_DEV_INTERFACE PPB_VIDEODECODER_DEV_INTERFACE_0_11 |
| +#define PPB_VIDEODECODER_DEV_INTERFACE_0_12 "PPB_VideoDecoder(Dev);0.12" |
| +#define PPB_VIDEODECODER_DEV_INTERFACE PPB_VIDEODECODER_DEV_INTERFACE_0_12 |
| // Video decoder interface. |
| // |
| // Typical usage: |
| // - Use Create() to get a new PPB_VideoDecoder_Dev resource. |
| // - Call Initialize() to create the underlying resources in the GPU process and |
| -// configure the decoder there. |
|
vrk (LEFT CHROMIUM)
2011/07/14 20:34:01
?
Ami GONE FROM CHROMIUM
2011/07/14 20:46:10
Done.
|
| // - Call Decode() to decode some video data. |
| // - Receive ProvidePictureBuffers callback |
| // - Supply the decoder with textures using AssignGLESBuffers. |
| @@ -27,7 +26,7 @@ |
| // callback. |
| // - To reset the decoder (e.g. to implement Seek): call Reset() and wait for |
| // NotifyResetDone callback. |
| -// - To tear down the decoder call Destroy() and wait for NotifyDestroyDone. |
| +// - To tear down the decoder call Destroy(). |
| // |
| // See PPP_VideoDecoder_Dev for the notifications the decoder may send the |
| // plugin. |
| @@ -132,18 +131,14 @@ struct PPB_VideoDecoder_Dev { |
| struct PP_CompletionCallback callback); |
| // Tear down the decoder as quickly as possible. Pending inputs and outputs |
| - // are dropped and the decoder frees all of its resources. When |callback| is |
| - // called the plugin is guaranteed not to receive any further callbacks and |
| - // must make no further calls on |video_decoder|. |
| + // are dropped and the decoder frees all of its resources. Although resources |
| + // may be freed asynchronously, after this method returns no more callbacks |
| + // will be made on the client. Any resources held by the client at that point |
| + // may be freed. |
| // |
| // Parameters: |
| // |video_decoder| is the previously created handle to the decoder resource. |
| - // |callback| is one-time callback that will be called once the destroy |
| - // request has been completed. |
| - // |
| - // Returns an error code from pp_errors.h. |
| - int32_t (*Destroy)(PP_Resource video_decoder, |
| - struct PP_CompletionCallback callback); |
| + void (*Destroy)(PP_Resource video_decoder); |
| }; |
| #endif /* PPAPI_C_DEV_PPB_VIDEO_DECODER_DEV_H_ */ |