Enable fire-and-forget Destroy of HW video decoder, and misc other improvements.

content/renderer/pepper_platform_video_decoder_impl.h

Index: content/renderer/pepper_platform_video_decoder_impl.h
diff --git a/content/renderer/pepper_platform_video_decoder_impl.h b/content/renderer/pepper_platform_video_decoder_impl.h
index b4d0d038b98453c2e1c2e8be1d3d215a686419f1..48309a986fc2779f93ebf1d8dbb0e3e68bad4953 100644
--- a/content/renderer/pepper_platform_video_decoder_impl.h
+++ b/content/renderer/pepper_platform_video_decoder_impl.h
@@ -25,9 +25,8 @@ class PlatformVideoDecoderImpl
       media::VideoDecodeAccelerator::Client* client,
       int32 command_buffer_route_id,
       gpu::CommandBufferHelper* cmd_buffer_helper);
-  virtual ~PlatformVideoDecoderImpl();
 
-  // PlatformVideoDecoder implementation.
+  // PlatformVideoDecoder (a.k.a. VideoDecodeAccelerator) implementation.
   virtual bool Initialize(const std::vector<uint32>& configs) OVERRIDE;
   virtual void Decode(
       const media::BitstreamBuffer& bitstream_buffer) OVERRIDE;
@@ -52,9 +51,10 @@ class PlatformVideoDecoderImpl
   virtual void NotifyEndOfBitstreamBuffer(int32 bitstream_buffer_id) OVERRIDE;
   virtual void NotifyFlushDone() OVERRIDE;
   virtual void NotifyResetDone() OVERRIDE;
-  virtual void NotifyDestroyDone() OVERRIDE;
 
  private:
+  virtual ~PlatformVideoDecoderImpl();
+
   // Client lifetime must exceed lifetime of this class.
   // TODO(vrk/fischman): We should take another look at the overall
   // arcitecture of PPAPI Video Decode to make sure lifetime/ownership makes
@@ -68,9 +68,7 @@ class PlatformVideoDecoderImpl
   gpu::CommandBufferHelper* cmd_buffer_helper_;
 
   // Host for GpuVideoDecodeAccelerator.

[vrk (LEFT CHROMIUM), 2011/07/14 20:34:01]

supernit: Maybe say "Holds a GpuVideoDecodeAcceleratorHost" instead

[Ami GONE FROM CHROMIUM, 2011/07/14 20:46:10]

Done.

-  // This is owned by the CommandBufferProxy associated with
-  // |command_buffer_route_id|.
-  media::VideoDecodeAccelerator* decoder_;
+  scoped_refptr<media::VideoDecodeAccelerator> decoder_;
 
   DISALLOW_COPY_AND_ASSIGN(PlatformVideoDecoderImpl);
 };