Makes sure widget is created at right size before showing

Makes sure widget is created at right size before showing
it. Previously if we were going to maximize the window we would first
create it at the restored size, then maximize it. On slower machines
this could result in a noticeable relayout of the web page.

BUG=11229
TEST=see bug.
R=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93067

[Ben Goodger (Google), 2011-07-13 23:53:40]

LGTM with one naming nit:

http://codereview.chromium.org/7358005/diff/1/views/widget/native_widget_win.cc
File views/widget/native_widget_win.cc (right):

http://codereview.chromium.org/7358005/diff/1/views/widget/native_widget_win....
views/widget/native_widget_win.cc:893: void
NativeWidgetWin::ShowNativeWidget(ShowState state) {
OK let's normalize these names.

Show()->Show()
ShowMaximized()->ShowMaximizedWithBounds()
ShowNativeWidget()->ShowWithState()

Otherwise it looks weird in Widget where you call ShowMaximized in one case or
ShowNativeWidget(SHOW_MAXIMIZED) in another.

[sky, 2011-07-18 21:30:55]

Oshima, could you review this? Ben gave it an LGTM for the first round, but I
had to change things around. I did run this idea by him and he was ok with the
idea.

Originally I had Widget calling GetSavedWindowBounds before the native widget
was created, but subclasses weren't prepared for this. I could have special
cased them, but it felt more correct to have an explicit method that is called
before the widget is created so it's easier for subclasses to deal. Neither
approach really feels that good to me. If you have a better idea, let me know.

  -Scott

[oshima, 2011-07-18 21:46:04]

ok, will do after chromeos ui mtg (3-4)

On Mon, Jul 18, 2011 at 2:30 PM, <sky@chromium.org> wrote:

> Oshima, could you review this? Ben gave it an LGTM for the first round, but
> I
> had to change things around. I did run this idea by him and he was ok with
> the
> idea.
>
> Originally I had Widget calling GetSavedWindowBounds before the native
> widget
> was created, but subclasses weren't prepared for this. I could have special
> cased them, but it felt more correct to have an explicit method that is
> called
> before the widget is created so it's easier for subclasses to deal. Neither
> approach really feels that good to me. If you have a better idea, let me
> know.
>
>  -Scott
>
>
http://codereview.chromium.**org/7358005/<http://codereview.chromium.org/7358...
>

[sky, 2011-07-19 16:08:09]

Updated to set bounds in InitParams rather than a new method.

  -Scott

[oshima, 2011-07-19 16:23:44]

LGTM

http://codereview.chromium.org/7358005/diff/11001/views/widget/widget.cc
File views/widget/widget.cc (right):

http://codereview.chromium.org/7358005/diff/11001/views/widget/widget.cc#newc...
views/widget/widget.cc:1035: widget_delegate_->GetSavedMaximizedState(maximize);
no need to change in this CL, but looks like all three parameters (maximized
state, bounds and hould_restore_window_size) can be in one struct like
SavedWindowState?