Makes sure widget is created at right size before showing

views/widget/native_widget_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/widget/native_widget_win.h"
 
 #include <dwmapi.h>
 #include <shellapi.h>
 
 #include "base/string_util.h"
@@ skipping 864 matching lines @@
     // NOTE: Be careful not to activate any windows here (for example, calling
     // ShowWindow(SW_HIDE) will automatically activate another window).  This
     // code can be called while a window is being deactivated, and activating
     // another window will screw up the activation that is already in progress.
     SetWindowPos(NULL, 0, 0, 0, 0,
                  SWP_HIDEWINDOW | SWP_NOACTIVATE | SWP_NOMOVE |
                  SWP_NOREPOSITION | SWP_NOSIZE | SWP_NOZORDER);
   }
 }
 
+void NativeWidgetWin::ShowMaximized(const gfx::Rect& restored_bounds) {
+  WINDOWPLACEMENT placement = { 0 };
+  placement.length = sizeof(WINDOWPLACEMENT);
+  placement.showCmd = SW_SHOWMAXIMIZED;
+  placement.rcNormalPosition = restored_bounds.ToRECT();
+  SetWindowPlacement(hwnd(), &placement);
+}
+
 void NativeWidgetWin::ShowNativeWidget(ShowState state) {

[Ben Goodger (Google), 2011/07/13 23:53:40]

OK let's normalize these names.

Show()->Show()
ShowMaximized()->ShowMaximizedWithBounds()
ShowNativeWidget()->ShowWithState()

Otherwise it looks weird in Widget where you call ShowMaximized in one case or
ShowNativeWidget(SHOW_MAXIMIZED) in another.

   DWORD native_show_state;
   switch (state) {
     case SHOW_INACTIVE:
       native_show_state = SW_SHOWNOACTIVATE;
       break;
     case SHOW_MAXIMIZED:
       native_show_state = SW_SHOWMAXIMIZED;
       break;
     default:
       native_show_state = GetShowState();
@@ skipping 1284 matching lines @@
   // Set non-style attributes.
   ownership_ = params.ownership;
 
   DWORD style = WS_CLIPCHILDREN | WS_CLIPSIBLINGS;
   DWORD ex_style = 0;
   DWORD class_style = CS_DBLCLKS;
 
   // Set type-independent style attributes.
   if (params.child)
     style |= WS_CHILD | WS_VISIBLE;
+  if (params.maximize)
+    style |= WS_MAXIMIZE;
   if (!params.accept_events)
     ex_style |= WS_EX_TRANSPARENT;
   if (!params.can_activate)
     ex_style |= WS_EX_NOACTIVATE;
   if (params.keep_on_top)
     ex_style |= WS_EX_TOPMOST;
   if (params.mirror_origin_in_rtl)
     ex_style |= l10n_util::GetExtendedTooltipStyles();
   if (params.transparent)
     ex_style |= WS_EX_LAYERED;
@@ skipping 328 matching lines @@
   return (GetKeyState(VK_LBUTTON) & 0x80) ||
     (GetKeyState(VK_RBUTTON) & 0x80) ||
     (GetKeyState(VK_MBUTTON) & 0x80) ||
     (GetKeyState(VK_XBUTTON1) & 0x80) ||
     (GetKeyState(VK_XBUTTON2) & 0x80);
 }
 
 }  // namespace internal
 
 }  // namespace views