Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2371)

Unified Diff: chrome/installer/util/installer_state.h

Issue 7353030: Cause new_chrome.exe to always be written if Chrome Frame is in use, resulting in updates being d... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/install_worker.cc ('k') | chrome/installer/util/installer_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/installer_state.h
===================================================================
--- chrome/installer/util/installer_state.h (revision 91508)
+++ chrome/installer/util/installer_state.h (working copy)
@@ -105,6 +105,11 @@
// TODO(grt): Eradicate the bool in favor of the enum.
bool is_multi_install() const;
+ // Returns whether or not there is currently a Chrome Frame instance running.
+ // Note that there isn't a mechanism to lock Chrome Frame in place, so Chrome
+ // Frame may either exit or start up after this is called.
+ bool is_chrome_frame_running() const { return is_chrome_frame_running_; }
+
// The full path to the place where the operand resides.
const FilePath& target_path() const { return target_path_; }
@@ -180,6 +185,8 @@
const std::wstring* launch_cmd) const;
protected:
+ static bool IsFileInUse(const FilePath& file);
+
FilePath GetDefaultProductInstallPath(BrowserDistribution* dist) const;
bool CanAddProduct(const Product& product, const FilePath* product_dir) const;
Product* AddProductInDirectory(const FilePath* product_dir,
@@ -190,6 +197,7 @@
const InstallationState& machine_state);
bool IsMultiInstallUpdate(const MasterPreferences& prefs,
const InstallationState& machine_state);
+ bool DetectChromeFrameInUse(const InstallationState& machine_state);
// Sets this object's level and updates the root_key_ accordingly.
void set_level(Level level);
@@ -211,6 +219,7 @@
#endif
bool msi_;
bool verbose_logging_;
+ bool is_chrome_frame_running_;
private:
DISALLOW_COPY_AND_ASSIGN(InstallerState);
« no previous file with comments | « chrome/installer/setup/install_worker.cc ('k') | chrome/installer/util/installer_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698