Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5925)

Unified Diff: chrome/installer/setup/install_worker.cc

Issue 7353030: Cause new_chrome.exe to always be written if Chrome Frame is in use, resulting in updates being d... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/first_run/upgrade_util_win.cc ('k') | chrome/installer/util/installer_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/install_worker.cc
===================================================================
--- chrome/installer/setup/install_worker.cc (revision 91508)
+++ chrome/installer/setup/install_worker.cc (working copy)
@@ -553,11 +553,23 @@
FilePath new_chrome_exe(target_path.Append(installer::kChromeNewExe));
install_list->AddDeleteTreeWorkItem(new_chrome_exe, temp_path);
- install_list->AddCopyTreeWorkItem(
- src_path.Append(installer::kChromeExe).value(),
- target_path.Append(installer::kChromeExe).value(),
- temp_path.value(), WorkItem::NEW_NAME_IF_IN_USE, new_chrome_exe.value());
+ if (installer_state.is_chrome_frame_running()) {
+ VLOG(1) << "Chrome Frame in use. Copying to new_chrome.exe";
+ install_list->AddCopyTreeWorkItem(
+ src_path.Append(installer::kChromeExe).value(),
+ new_chrome_exe.value(),
+ temp_path.value(),
+ WorkItem::ALWAYS);
+ } else {
+ install_list->AddCopyTreeWorkItem(
+ src_path.Append(installer::kChromeExe).value(),
+ target_path.Append(installer::kChromeExe).value(),
+ temp_path.value(),
+ WorkItem::NEW_NAME_IF_IN_USE,
+ new_chrome_exe.value());
+ }
+
// Extra executable for 64 bit systems.
// NOTE: We check for "not disabled" so that if the API call fails, we play it
// safe and copy the executable anyway.
« no previous file with comments | « chrome/browser/first_run/upgrade_util_win.cc ('k') | chrome/installer/util/installer_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698