base/logging.h - Issue 7352014: Revert "Add COMPONENT_BUILD global define. "

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.h

Issue 7352014: Revert "Add COMPONENT_BUILD global define. " (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/logging.h

diff --git a/base/logging.h b/base/logging.h

index d0989376e9b79609c54d3ad897d2fc13d11d2aed..849de0e33292ffdb1b217b94c5fece07bd38ab5f 100644

--- a/base/logging.h

+++ b/base/logging.h

@@ -469,7 +469,7 @@ std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) {

}

// MSVC doesn't like complex extern templates and DLLs.

-#if !defined(COMPILER_MSVC) && defined(COMPONENT_BUILD)

+#if !defined(COMPILER_MSVC) && defined(BASE_DLL)

// Commonly used instantiations of MakeCheckOpString<>. Explicitly instantiated

// in logging.cc.

extern template std::string* MakeCheckOpString<int, int>(

« no previous file with comments | « base/debug/debug_on_start_win.h ('k') | build/common.gypi » ('j') | no next file with comments »