Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7346024: Get rid of the ProfileId. It was added for ceee. I reverted the original change, since it led to ... (Closed)

Created:
9 years, 5 months ago by jam
Modified:
9 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, achuith+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, Roger Tawa OOO till Jul 10th
Visibility:
Public.

Description

Get rid of the ProfileId. It was added for ceee. I reverted the original change, since it led to Profile being used in content unnecessarily. I also removed the extensions usage of it and instead kept a void*. BUG=76788 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92382

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : sync #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -368 lines) Patch
M chrome/browser/extensions/extension_event_router.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_event_router_forwarder.h View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_event_router_forwarder.cc View 1 2 3 4 5 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_event_router_forwarder_unittest.cc View 1 2 3 4 5 7 chunks +7 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_function.h View 1 2 3 4 5 6 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_function.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 2 3 4 5 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_proxy_api.h View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_proxy_api.cc View 1 2 3 4 5 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_tts_engine_api.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_webrequest_api.h View 1 2 3 4 5 9 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/extensions/extension_webrequest_api.cc View 1 2 3 4 5 30 chunks +63 lines, -64 lines 0 comments Download
M chrome/browser/extensions/extension_webrequest_api_unittest.cc View 1 2 3 4 5 6 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate.h View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 2 3 4 5 6 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 2 3 4 5 4 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 2 3 4 5 5 chunks +8 lines, -18 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 2 3 4 5 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 3 4 5 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_drag_data.h View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_drag_data.cc View 1 2 3 4 5 6 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/testing_profile.h View 1 2 3 4 5 2 chunks +1 line, -25 lines 0 comments Download
M chrome/test/testing_profile.cc View 1 2 3 4 5 2 chunks +0 lines, -13 lines 0 comments Download
M content/browser/browsing_instance.h View 1 2 3 4 5 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/browsing_instance.cc View 1 2 3 4 5 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/site_instance_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -67 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
9 years, 5 months ago (2011-07-12 22:32:58 UTC) #1
jochen (gone - plz use gerrit)
LGTM http://codereview.chromium.org/7346024/diff/5008/chrome/browser/profiles/profile.h File chrome/browser/profiles/profile.h (right): http://codereview.chromium.org/7346024/diff/5008/chrome/browser/profiles/profile.h#newcode578 chrome/browser/profiles/profile.h:578: #endif no indenting?
9 years, 5 months ago (2011-07-12 22:52:13 UTC) #2
jam
http://codereview.chromium.org/7346024/diff/5008/chrome/browser/profiles/profile.h File chrome/browser/profiles/profile.h (right): http://codereview.chromium.org/7346024/diff/5008/chrome/browser/profiles/profile.h#newcode578 chrome/browser/profiles/profile.h:578: #endif On 2011/07/12 22:52:13, jochen wrote: > no indenting? ...
9 years, 5 months ago (2011-07-12 23:19:44 UTC) #3
jochen (gone - plz use gerrit)
http://codereview.chromium.org/7346024/diff/5008/chrome/browser/profiles/profile.h File chrome/browser/profiles/profile.h (right): http://codereview.chromium.org/7346024/diff/5008/chrome/browser/profiles/profile.h#newcode578 chrome/browser/profiles/profile.h:578: #endif On 2011/07/12 23:19:44, John Abd-El-Malek wrote: > On ...
9 years, 5 months ago (2011-07-13 18:41:56 UTC) #4
jam
9 years, 5 months ago (2011-07-13 20:04:31 UTC) #5 
http://codereview.chromium.org/7346024/diff/5008/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile.h (right):

http://codereview.chromium.org/7346024/diff/5008/chrome/browser/profiles/prof...
chrome/browser/profiles/profile.h:578: #endif
On 2011/07/13 18:41:56, jochen wrote:
> On 2011/07/12 23:19:44, John Abd-El-Malek wrote:
> > On 2011/07/12 22:52:13, jochen wrote:
> > > no indenting?
> > 
> > I'm not sure where you mean we should indent? We don't indent inside an
ifdef
> or
> > a namespace (btw I just copied this code from the deleted version).
> 
> at least in rietvield it looks like the whole block is indented one space - it
> shouldn't 

ah i see that now (couldn't see it earlier!), will fix in a followup

Powered by Google App Engine
This is Rietveld 408576698