Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/browser/extensions/extension_proxy_api.cc

Issue 7346024: Get rid of the ProfileId. It was added for ceee. I reverted the original change, since it led to ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Implementation of the Chrome Extensions Proxy Settings API. 5 // Implementation of the Chrome Extensions Proxy Settings API.
6 6
7 #include "chrome/browser/extensions/extension_proxy_api.h" 7 #include "chrome/browser/extensions/extension_proxy_api.h"
8 8
9 #include "base/json/json_writer.h" 9 #include "base/json/json_writer.h"
10 #include "base/stringprintf.h" 10 #include "base/stringprintf.h"
(...skipping 15 matching lines...) Expand all
26 } 26 }
27 27
28 ExtensionProxyEventRouter::ExtensionProxyEventRouter() { 28 ExtensionProxyEventRouter::ExtensionProxyEventRouter() {
29 } 29 }
30 30
31 ExtensionProxyEventRouter::~ExtensionProxyEventRouter() { 31 ExtensionProxyEventRouter::~ExtensionProxyEventRouter() {
32 } 32 }
33 33
34 void ExtensionProxyEventRouter::OnProxyError( 34 void ExtensionProxyEventRouter::OnProxyError(
35 ExtensionEventRouterForwarder* event_router, 35 ExtensionEventRouterForwarder* event_router,
36 ProfileId profile_id, 36 void* profile,
37 int error_code) { 37 int error_code) {
38 ListValue args; 38 ListValue args;
39 DictionaryValue* dict = new DictionaryValue(); 39 DictionaryValue* dict = new DictionaryValue();
40 dict->SetBoolean(keys::kProxyEventFatal, true); 40 dict->SetBoolean(keys::kProxyEventFatal, true);
41 dict->SetString(keys::kProxyEventError, net::ErrorToString(error_code)); 41 dict->SetString(keys::kProxyEventError, net::ErrorToString(error_code));
42 dict->SetString(keys::kProxyEventDetails, ""); 42 dict->SetString(keys::kProxyEventDetails, "");
43 args.Append(dict); 43 args.Append(dict);
44 44
45 std::string json_args; 45 std::string json_args;
46 base::JSONWriter::Write(&args, false, &json_args); 46 base::JSONWriter::Write(&args, false, &json_args);
47 47
48 if (profile_id != Profile::kInvalidProfileId) { 48 if (profile) {
49 event_router->DispatchEventToRenderers( 49 event_router->DispatchEventToRenderers(
50 keys::kProxyEventOnProxyError, json_args, profile_id, true, GURL()); 50 keys::kProxyEventOnProxyError, json_args, profile, true, GURL());
51 } else { 51 } else {
52 event_router->BroadcastEventToRenderers( 52 event_router->BroadcastEventToRenderers(
53 keys::kProxyEventOnProxyError, json_args, GURL()); 53 keys::kProxyEventOnProxyError, json_args, GURL());
54 } 54 }
55 } 55 }
56 56
57 void ExtensionProxyEventRouter::OnPACScriptError( 57 void ExtensionProxyEventRouter::OnPACScriptError(
58 ExtensionEventRouterForwarder* event_router, 58 ExtensionEventRouterForwarder* event_router,
59 ProfileId profile_id, 59 void* profile,
60 int line_number, 60 int line_number,
61 const string16& error) { 61 const string16& error) {
62 ListValue args; 62 ListValue args;
63 DictionaryValue* dict = new DictionaryValue(); 63 DictionaryValue* dict = new DictionaryValue();
64 dict->SetBoolean(keys::kProxyEventFatal, false); 64 dict->SetBoolean(keys::kProxyEventFatal, false);
65 dict->SetString(keys::kProxyEventError, 65 dict->SetString(keys::kProxyEventError,
66 net::ErrorToString(net::ERR_PAC_SCRIPT_FAILED)); 66 net::ErrorToString(net::ERR_PAC_SCRIPT_FAILED));
67 std::string error_msg; 67 std::string error_msg;
68 if (line_number != -1) { 68 if (line_number != -1) {
69 base::SStringPrintf( 69 base::SStringPrintf(
70 &error_msg, "line: %d: %s", line_number, UTF16ToUTF8(error).c_str()); 70 &error_msg, "line: %d: %s", line_number, UTF16ToUTF8(error).c_str());
71 } else { 71 } else {
72 error_msg = UTF16ToUTF8(error); 72 error_msg = UTF16ToUTF8(error);
73 } 73 }
74 dict->SetString(keys::kProxyEventDetails, error_msg); 74 dict->SetString(keys::kProxyEventDetails, error_msg);
75 args.Append(dict); 75 args.Append(dict);
76 76
77 std::string json_args; 77 std::string json_args;
78 base::JSONWriter::Write(&args, false, &json_args); 78 base::JSONWriter::Write(&args, false, &json_args);
79 79
80 if (profile_id != Profile::kInvalidProfileId) { 80 if (profile) {
81 event_router->DispatchEventToRenderers( 81 event_router->DispatchEventToRenderers(
82 keys::kProxyEventOnProxyError, json_args, profile_id, true, GURL()); 82 keys::kProxyEventOnProxyError, json_args, profile, true, GURL());
83 } else { 83 } else {
84 event_router->BroadcastEventToRenderers( 84 event_router->BroadcastEventToRenderers(
85 keys::kProxyEventOnProxyError, json_args, GURL()); 85 keys::kProxyEventOnProxyError, json_args, GURL());
86 } 86 }
87 } 87 }
88 88
89 ProxyPrefTransformer::ProxyPrefTransformer() { 89 ProxyPrefTransformer::ProxyPrefTransformer() {
90 } 90 }
91 91
92 ProxyPrefTransformer::~ProxyPrefTransformer() { 92 ProxyPrefTransformer::~ProxyPrefTransformer() {
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 if (!proxy_rules_dict) 175 if (!proxy_rules_dict)
176 return NULL; 176 return NULL;
177 extension_pref->Set(keys::kProxyConfigRules, proxy_rules_dict); 177 extension_pref->Set(keys::kProxyConfigRules, proxy_rules_dict);
178 break; 178 break;
179 } 179 }
180 case ProxyPrefs::kModeCount: 180 case ProxyPrefs::kModeCount:
181 NOTREACHED(); 181 NOTREACHED();
182 } 182 }
183 return extension_pref.release(); 183 return extension_pref.release();
184 } 184 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_proxy_api.h ('k') | chrome/browser/extensions/extension_tts_engine_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698