Issue 7346006: Fixed a long-standing TODO: Removed a few *-incl.h #includes from isolate.h.

Issue 7346006: Fixed a long-standing TODO: Removed a few *-incl.h #includes from isolate.h. (Closed)

Created:
9 years, 5 months ago by Sven Panne

Modified:
9 years, 5 months ago

Reviewers:
Søren Thygesen Gjesse, danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixed a long-standing TODO: Removed a few *-incl.h #includes from isolate.h. ZoneAllocationPolicy::New is not inlined anymore because this pulls in far too much stuff and doesn't really make any measurable performance difference. And no, the #includes are still not in alphabetical order... ;-) Committed: http://code.google.com/p/v8/source/detail?r=8616

Patch Set 1 #

Total comments: 4

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -11 lines)			Patch
M	src/allocation.h	View	2 chunks	+2 lines, -1 line	4 comments	Download
M	src/debug.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/frames.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/isolate.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/scopeinfo.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/scopes.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/string-stream.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/type-info.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/zone.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/7346006/diff/1/src/allocation.h File src/allocation.h (right): http://codereview.chromium.org/7346006/diff/1/src/allocation.h#newcode1 src/allocation.h:1: // Copyright 2008-2011 the V8 project authors. All ...

9 years, 5 months ago (2011-07-12 07:43:22 UTC) #2

Sven Panne

9 years, 5 months ago (2011-07-12 07:57:18 UTC) #5

http://codereview.chromium.org/7346006/diff/1/src/allocation.h
File src/allocation.h (right):

http://codereview.chromium.org/7346006/diff/1/src/allocation.h#newcode1
src/allocation.h:1: // Copyright 2008-2011 the V8 project authors. All rights
reserved.
On 2011/07/12 07:43:22, Søren Gjesse wrote:
> Just 2011 instead of 2008-2011 (in other files as well).

Done.

http://codereview.chromium.org/7346006/diff/1/src/allocation.h#newcode31
src/allocation.h:31: #include "allocation.h"
On 2011/07/12 07:43:22, Søren Gjesse wrote:
> No need for this file to include itself.

Done.

Expand Messages | Collapse Messages