Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

Issue 7328018: Migrate default geolocation content setting to host content settings map. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
diff --git a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
index c05422c7e2cd7ef9a49a564b99fbac43b9a7bd28..f42c7926d0d46ae6233c37cf676acf8dfcc4114b 100644
--- a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
+++ b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
@@ -55,6 +55,13 @@ TEST_F(PrefDefaultProviderTest, DefaultValues) {
CONTENT_SETTING_BLOCK);
EXPECT_EQ(CONTENT_SETTING_BLOCK,
provider_.ProvideDefaultSetting(CONTENT_SETTINGS_TYPE_COOKIES));
+
+ EXPECT_EQ(CONTENT_SETTING_ASK,
+ provider_.ProvideDefaultSetting(CONTENT_SETTINGS_TYPE_GEOLOCATION));
+ provider_.UpdateDefaultSetting(CONTENT_SETTINGS_TYPE_GEOLOCATION,
+ CONTENT_SETTING_BLOCK);
+ EXPECT_EQ(CONTENT_SETTING_BLOCK,
+ provider_.ProvideDefaultSetting(CONTENT_SETTINGS_TYPE_GEOLOCATION));
}
TEST_F(PrefDefaultProviderTest, Observer) {
@@ -68,6 +75,12 @@ TEST_F(PrefDefaultProviderTest, Observer) {
provider_.UpdateDefaultSetting(
CONTENT_SETTINGS_TYPE_IMAGES, CONTENT_SETTING_BLOCK);
+
+ EXPECT_CALL(mock_observer,
+ OnContentSettingChanged(
+ _, _, CONTENT_SETTINGS_TYPE_GEOLOCATION, ""));
+ provider_.UpdateDefaultSetting(
+ CONTENT_SETTINGS_TYPE_GEOLOCATION, CONTENT_SETTING_BLOCK);
}
TEST_F(PrefDefaultProviderTest, ObserveDefaultPref) {
@@ -126,6 +139,33 @@ TEST_F(PrefDefaultProviderTest, OffTheRecord) {
otr_provider.ShutdownOnUIThread();
}
+TEST_F(PrefDefaultProviderTest, MigrateDefaultGeolocationContentSetting) {
+ TestingProfile profile;
+ TestingPrefService* prefs = profile.GetTestingPrefService();
+
+ // Set obsolete preference and test if it is migrated correctly.
+ prefs->SetInteger(prefs::kGeolocationDefaultContentSetting,
+ CONTENT_SETTING_ALLOW);
+ PrefDefaultProvider provider(prefs, false);
+
+ MockObserver mock_observer;
+ EXPECT_CALL(mock_observer,
+ OnContentSettingChanged(
+ _, _, CONTENT_SETTINGS_TYPE_GEOLOCATION, ""));
+ provider.AddObserver(&mock_observer);
+
+ EXPECT_EQ(CONTENT_SETTING_ALLOW,
+ provider.ProvideDefaultSetting(CONTENT_SETTINGS_TYPE_GEOLOCATION));
+
+ // Change obsolete preference and test if it migrated correctly.
+ prefs->SetInteger(prefs::kGeolocationDefaultContentSetting,
+ CONTENT_SETTING_BLOCK);
+ EXPECT_EQ(CONTENT_SETTING_BLOCK,
+ provider.ProvideDefaultSetting(CONTENT_SETTINGS_TYPE_GEOLOCATION));
+
+ provider.ShutdownOnUIThread();
+}
+
// ////////////////////////////////////////////////////////////////////////////
// PrefProviderTest
//

Powered by Google App Engine
This is Rietveld 408576698