Issue 7328018: Migrate default geolocation content setting to host content settings map.

Issue 7328018: Migrate default geolocation content setting to host content settings map. (Closed)

Created:
9 years, 5 months ago by markusheintz_

Modified:
9 years, 5 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, Paweł Hajdan Jr., jochen (gone - plz use gerrit)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Migrate default geolocation content setting to host content settings map. BUG=63656 TEST=geolocation_content_settings_map_unittest.cc, content_settings_pref_provider_unittest.cc, host_content_settings_map_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93018

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Patch Set 4 : " #

Patch Set 5 : " #

Total comments: 6

Patch Set 6 : fix nits #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -106 lines)			Patch
M	chrome/browser/content_settings/content_settings_policy_provider.cc	View	1 2	4 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/content_settings/content_settings_policy_provider_unittest.cc	View	1 2 3 4 5	1 chunk	+38 lines, -0 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_pref_provider.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_pref_provider.cc	View	1 2 3 4	10 chunks	+34 lines, -5 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_pref_provider_unittest.cc	View	1 2 3 4	3 chunks	+40 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_content_settings_map.h	View	1 2	3 chunks	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_content_settings_map.cc	View	1 2 3	7 chunks	+14 lines, -44 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc	View	1 2 3 4 5	6 chunks	+17 lines, -18 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_settings_state.cc	View	1 2 3 4 5	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_pref_store.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/content_settings_handler.cc	View	1 2 3	5 chunks	+6 lines, -17 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

markusheintz_

Please review my CL. Please note chrome/browser/geolocation/geolocation_content_settings_map.cc:179 . I didn't remove this if yet on ...

9 years, 5 months ago (2011-07-15 13:18:10 UTC) #1

Bernhard Bauer

LGTM w/ nits: http://codereview.chromium.org/7328018/diff/8001/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc File chrome/browser/content_settings/content_settings_policy_provider_unittest.cc (right): http://codereview.chromium.org/7328018/diff/8001/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc#newcode72 chrome/browser/content_settings/content_settings_policy_provider_unittest.cc:72: // Nit: Why the empty comment? ...

9 years, 5 months ago (2011-07-15 13:31:44 UTC) #2

markusheintz_

9 years, 5 months ago (2011-07-15 16:21:50 UTC) #3

Thanks

http://codereview.chromium.org/7328018/diff/8001/chrome/browser/content_setti...
File
chrome/browser/content_settings/content_settings_policy_provider_unittest.cc
(right):

http://codereview.chromium.org/7328018/diff/8001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_policy_provider_unittest.cc:72:
//
On 2011/07/15 13:31:44, Bernhard Bauer wrote:
> Nit: Why the empty comment?
Sry. Removed

http://codereview.chromium.org/7328018/diff/8001/chrome/browser/geolocation/g...
File chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc
(right):

http://codereview.chromium.org/7328018/diff/8001/chrome/browser/geolocation/g...
chrome/browser/geolocation/geolocation_content_settings_map_unittest.cc:304: //
preference obsolete kGeolocationDefaultContentSetting was changed.
On 2011/07/15 13:31:44, Bernhard Bauer wrote:
> Nit: swap "preference" and "obsolete".

Done.

http://codereview.chromium.org/7328018/diff/8001/chrome/browser/geolocation/g...
File chrome/browser/geolocation/geolocation_settings_state.cc (right):

http://codereview.chromium.org/7328018/diff/8001/chrome/browser/geolocation/g...
chrome/browser/geolocation/geolocation_settings_state.cc:60: const
ContentSetting default_setting =
On 2011/07/15 13:31:44, Bernhard Bauer wrote:
> Nit: the |const| before |ContentSetting| isn't really necessary.

Done.

Expand Messages | Collapse Messages