Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 7327030: Fixed bug that caused canvas updates to trigger two compositor paints. (Closed)

Created:
9 years, 5 months ago by jbates
Modified:
9 years, 5 months ago
Reviewers:
jamesr, nduca
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, Vangelis Kokkevis
Visibility:
Public.

Description

Fixed bug that caused canvas updates to trigger two compositor paints. LayerRendererChromium::updateLayers was triggering a scheduleComposite because the paint aggregator in RenderWidget was emptied beforehand. This change (in combination with the webkit-side patch https://bugs.webkit.org/show_bug.cgi?id=64224) delays the paint aggregator emptying until after updateLayers and before paint. The webkit patch must land before this one. BUG=84887 TEST=www/~jbates/test/double_frames/ should run at about 10 fps; if it's closer to 20, there is a bug

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -42 lines) Patch
M content/renderer/render_widget.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +53 lines, -42 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
jbates
http://codereview.chromium.org/7327030/diff/1/content/renderer/render_widget.cc File content/renderer/render_widget.cc (left): http://codereview.chromium.org/7327030/diff/1/content/renderer/render_widget.cc#oldcode789 content/renderer/render_widget.cc:789: HISTOGRAM_COUNTS_100("MPArch.RW_PaintRectCount", update.paint_rects.size()); None of this code block has changed ...
9 years, 5 months ago (2011-07-09 02:06:19 UTC) #1
nduca
Is this patch still current in light of wkbug64224's current state?
9 years, 5 months ago (2011-07-12 16:54:26 UTC) #2
jbates
9 years, 5 months ago (2011-07-12 17:16:46 UTC) #3
On 2011/07/12 16:54:26, nduca wrote:
> Is this patch still current in light of wkbug64224's current state?

Probably not, no need to review for now, still testing the other side though.

Powered by Google App Engine
This is Rietveld 408576698