about://appcache-internals enhancements

webkit/appcache/view_appcache_internals_job.h

Index: webkit/appcache/view_appcache_internals_job.h
===================================================================
--- webkit/appcache/view_appcache_internals_job.h	(revision 91517)
+++ webkit/appcache/view_appcache_internals_job.h	(working copy)
@@ -5,53 +5,24 @@
 #ifndef WEBKIT_APPCACHE_VIEW_APPCACHE_INTERNALS_JOB_H_
 #define WEBKIT_APPCACHE_VIEW_APPCACHE_INTERNALS_JOB_H_
 
-#include <string>
+#include "base/basictypes.h"
 
-#include "net/url_request/url_request_simple_job.h"
-#include "webkit/appcache/appcache_service.h"
-
 namespace net {
 class URLRequest;
-}  // namespace net
+class URLRequestJob;
+}
 
 namespace appcache {
 
-// A job subclass that implements a protocol to inspect the internal
-// state of appcache service.
-class ViewAppCacheInternalsJob : public net::URLRequestSimpleJob {
+class AppCacheService;
+
+class ViewAppCacheInternalsJobFactory {

[rvargas (doing something else), 2011/07/11 22:34:07]

I'm wondering if we should rename this file to xx_factory.h

[michaeln, 2011/07/12 23:35:26]

AppCacheInternalsJobFactory.h maybe?

[rvargas (doing something else), 2011/07/13 02:07:14]

yeah, that also works... 

  public:
-  // Stores handle to appcache service for getting information.
-  ViewAppCacheInternalsJob(net::URLRequest* request, AppCacheService* service);
+  static net::URLRequestJob* CreateJobForRequest(
+      net::URLRequest* request, AppCacheService* service);
 
-  // Fetches the AppCache Info and calls StartAsync after it is done.
-  virtual void Start();
-
-  virtual bool GetData(std::string* mime_type,
-                       std::string* charset,
-                       std::string* data) const;
-
-  // Overridden method from net::URLRequestJob.
-  virtual bool IsRedirectResponse(GURL* location, int* http_status_code);
-
  private:
-  virtual ~ViewAppCacheInternalsJob();
-
-  void AppCacheDone(int rv);
-
-  // Adds HTML from appcache information to out.
-  void GenerateHTMLAppCacheInfo(std::string* out) const;
-  void GetAppCacheInfoAsync();
-  void RemoveAppCacheInfoAsync(const std::string& manifest_url_spec);
-
-  // This is a common callback for both remove and getinfo for appcache.
-  scoped_refptr<net::CancelableCompletionCallback<ViewAppCacheInternalsJob> >
-      appcache_done_callback_;
-
-  scoped_refptr<AppCacheInfoCollection> info_collection_;
-  // Not owned.
-  AppCacheService* appcache_service_;
-
-  DISALLOW_COPY_AND_ASSIGN(ViewAppCacheInternalsJob);
+  DISALLOW_IMPLICIT_CONSTRUCTORS(ViewAppCacheInternalsJobFactory);
 };
 
 }  // namespace appcache