about://appcache-internals enhancements

webkit/appcache/appcache_host.cc

Index: webkit/appcache/appcache_host.cc
===================================================================
--- webkit/appcache/appcache_host.cc	(revision 91517)
+++ webkit/appcache/appcache_host.cc	(working copy)
@@ -279,21 +279,8 @@
 
 void AppCacheHost::GetResourceList(
     std::vector<AppCacheResourceInfo>* resource_infos) {

[rvargas (doing something else), 2011/07/11 22:34:07]

nit: use AppCacheResourceInfoVector here?

[michaeln, 2011/07/12 23:35:26]

Done.

-  if (associated_cache_.get() && associated_cache_->is_complete()) {
-    for (AppCache::EntryMap::const_iterator it =
-         associated_cache_->entries().begin();
-         it != associated_cache_->entries().end(); ++it) {
-      AppCacheResourceInfo info;
-      info.url = it->first;
-      info.is_master = it->second.IsMaster();
-      info.is_manifest = it->second.IsManifest();
-      info.is_fallback = it->second.IsFallback();
-      info.is_foreign = it->second.IsForeign();
-      info.is_explicit = it->second.IsExplicit();
-      info.size = it->second.response_size();
-      resource_infos->push_back(info);
-    }
-  }
+  if (associated_cache_.get() && associated_cache_->is_complete())
+    associated_cache_->ToResourceInfoVector(resource_infos);
 }
 
 Status AppCacheHost::GetStatus() {