Issue 7316023: When GL implementation is Mock or None return rather than setting the skia-gpu GL interface with ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7316023: When GL implementation is Mock or None return rather than setting the skia-gpu GL interface with ... (Closed)

Created:
9 years, 5 months ago by bsalomon

Modified:
9 years, 5 months ago

Reviewers:
apatrick, twiz, apatrick_chromium, Jeff Timanus

CC:
chromium-reviews, Nico

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

When GL implementation is Mock or None return rather than setting the skia-gpu GL interface with an uninitialized binding. Fixes a -Werror issue. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91763

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	ui/gfx/gl/gl_bindings_skia_in_process.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

bsalomon

PTAL apatrick for OWNERS review. twiz is familiar with this code (initially wrote it) The ...

9 years, 5 months ago (2011-07-07 19:29:54 UTC) #1

LGTM.