Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: chrome/browser/pdf_unsupported_feature.cc

Issue 7314020: Update UMA user actions parsing, primarily to include WebUI metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/pdf_unsupported_feature.cc
diff --git a/chrome/browser/pdf_unsupported_feature.cc b/chrome/browser/pdf_unsupported_feature.cc
index 0e68c0a978d379bcfc8eb9d0c8aff175239a6fa9..90c87b6febf1586e7b3b1a598993993fb2c31bbb 100644
--- a/chrome/browser/pdf_unsupported_feature.cc
+++ b/chrome/browser/pdf_unsupported_feature.cc
@@ -349,8 +349,12 @@ bool PDFUnsupportedFeatureInfoBarDelegate::OnYes() {
}
void PDFUnsupportedFeatureInfoBarDelegate::OnNo() {
- UserMetrics::RecordAction(UserMetricsAction(reader_installed_ ?
James Hawkins 2011/07/07 16:30:50 What's wrong with this version?
Ilya Sherman 2011/07/07 18:59:44 This script scans for the literal string """ UserM
James Hawkins 2011/07/07 20:44:19 Yea, I think I prefer that. It's at least in the s
Ilya Sherman 2011/07/07 21:01:01 Ok, switched to that style.
- "PDF_UseReaderInfoBarCancel" : "PDF_InstallReaderInfoBarCancel"));
+ if (reader_installed_) {
+ UserMetrics::RecordAction(UserMetricsAction("PDF_UseReaderInfoBarCancel"));
+ } else {
+ UserMetrics::RecordAction(
+ UserMetricsAction("PDF_InstallReaderInfoBarCancel"));
+ }
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698