Update UMA user actions parsing, primarily to include WebUI metrics.

chrome/browser/pdf_unsupported_feature.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/pdf_unsupported_feature.h"
 
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "base/version.h"
 #include "chrome/browser/prefs/pref_service.h"
@@ skipping 331 matching lines @@
         new PDFEnableAdobeReaderInfoBarDelegate(tab_contents_->tab_contents());
     OpenUsingReader(tab_contents_, reader_webplugininfo_, this, bar);
     return false;
   }
 
   OpenUsingReader(tab_contents_, reader_webplugininfo_, NULL, NULL);
   return true;
 }
 
 void PDFUnsupportedFeatureInfoBarDelegate::OnNo() {
-  UserMetrics::RecordAction(UserMetricsAction(reader_installed_ ?

[James Hawkins, 2011/07/07 16:30:50]

What's wrong with this version?

[Ilya Sherman, 2011/07/07 18:59:44]

This script scans for the literal string """ UserMetricsAction(" """ to detect
metrics used with UserMetrics::RecordAction.  I could rewrite this as

UserMetrics::RecordAction(reader_installed_ ?
    UserMetricsAction("PDF_UseReaderInfoBarCancel") :
    UserMetricsAction("PDF_InstallReaderInfoBarCancel"));

if that style is preferable.

[James Hawkins, 2011/07/07 20:44:19]

Yea, I think I prefer that. It's at least in the spirit of the old code.

[Ilya Sherman, 2011/07/07 21:01:01]

Ok, switched to that style.

-      "PDF_UseReaderInfoBarCancel" : "PDF_InstallReaderInfoBarCancel"));
+  if (reader_installed_) {
+    UserMetrics::RecordAction(UserMetricsAction("PDF_UseReaderInfoBarCancel"));
+  } else {
+    UserMetrics::RecordAction(
+        UserMetricsAction("PDF_InstallReaderInfoBarCancel"));
+  }
 }
 
 }  // namespace
 
 void PDFHasUnsupportedFeature(TabContentsWrapper* tab) {
 #if !defined(OS_WIN)
   // Only works for Windows for now.  For Mac, we'll have to launch the file
   // externally since Adobe Reader doesn't work inside Chrome.
   return;
 #endif
   string16 reader_group_name(ASCIIToUTF16(PluginGroup::kAdobeReaderGroupName));
 
   // If the Reader plugin is disabled by policy, don't prompt them.
   if (PluginGroup::IsPluginNameDisabledByPolicy(reader_group_name))
     return;
 
   PluginGroup* reader_group = NULL;
   std::vector<PluginGroup> plugin_groups;
   PluginList::Singleton()->GetPluginGroups(
       false, &plugin_groups);
   for (size_t i = 0; i < plugin_groups.size(); ++i) {
     if (plugin_groups[i].GetGroupName() == reader_group_name) {
       reader_group = &plugin_groups[i];
       break;
     }
   }
 
   tab->AddInfoBar(new PDFUnsupportedFeatureInfoBarDelegate(tab, reader_group));
 }