Implement Object.defineProperty for proxies.

Implement Object.defineProperty for proxies.

R=kmillikin@chromium.org
BUG=
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=8564

[Kevin Millikin (Chromium), 2011-07-07 08:12:02]

LGTM.

http://codereview.chromium.org/7314003/diff/1/src/messages.js
File src/messages.js (right):

http://codereview.chromium.org/7314003/diff/1/src/messages.js#newcode198
src/messages.js:198: handler_failed:               ["Proxy handler ", "%0", "
returned false for '", "%1", "' trap"],
I wonder if there's a better message?  Couldn't the handler have returned 0 or
undefined or...?

I have no concrete suggestion right now.

http://codereview.chromium.org/7314003/diff/1/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/7314003/diff/1/src/v8natives.js#newcode361
src/v8natives.js:361: if (desc.hasValue_) obj.value = desc.getValue();
It's not obvious why you use the property hasValue_ in the test and the accessor
getValue() in the assignment.

http://codereview.chromium.org/7314003/diff/1/test/mjsunit/harmony/proxies.js
File test/mjsunit/harmony/proxies.js (right):

http://codereview.chromium.org/7314003/diff/1/test/mjsunit/harmony/proxies.js...
test/mjsunit/harmony/proxies.js:181: delete attributes.midetoo
midetoo => minetoo

[rossberg, 2011-07-07 09:19:32]

http://codereview.chromium.org/7314003/diff/1/src/messages.js
File src/messages.js (right):

http://codereview.chromium.org/7314003/diff/1/src/messages.js#newcode198
src/messages.js:198: handler_failed:               ["Proxy handler ", "%0", "
returned false for '", "%1", "' trap"],
On 2011/07/07 08:12:02, Kevin Millikin wrote:
> I wonder if there's a better message?  Couldn't the handler have returned 0 or
> undefined or...?
> 
> I have no concrete suggestion right now.

Hm, me neither. The return type morally is a Boolean, so I guess users will know
how to read this.

http://codereview.chromium.org/7314003/diff/1/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/7314003/diff/1/src/v8natives.js#newcode361
src/v8natives.js:361: if (desc.hasValue_) obj.value = desc.getValue();
On 2011/07/07 08:12:02, Kevin Millikin wrote:
> It's not obvious why you use the property hasValue_ in the test and the
accessor
> getValue() in the assignment.

True. I copied from pre-existing functions. I fixed those, too.

http://codereview.chromium.org/7314003/diff/1/test/mjsunit/harmony/proxies.js
File test/mjsunit/harmony/proxies.js (right):

http://codereview.chromium.org/7314003/diff/1/test/mjsunit/harmony/proxies.js...
test/mjsunit/harmony/proxies.js:181: delete attributes.midetoo
On 2011/07/07 08:12:02, Kevin Millikin wrote:
> midetoo => minetoo

Done.