Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: src/messages.js

Issue 7314003: Implement Object.defineProperty for proxies. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | src/v8natives.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.js
diff --git a/src/messages.js b/src/messages.js
index 841c5180a3df0c7d24a82d1b52e56b576454c3b7..b9281070a7670f6d38b1e7e5ddea603d551e9cc2 100644
--- a/src/messages.js
+++ b/src/messages.js
@@ -195,6 +195,7 @@ function FormatMessage(message) {
non_extensible_proto: ["%0", " is not extensible"],
handler_non_object: ["Proxy.", "%0", " called with non-object as handler"],
handler_trap_missing: ["Proxy handler ", "%0", " has no '", "%1", "' trap"],
+ handler_failed: ["Proxy handler ", "%0", " returned false for '", "%1", "' trap"],
Kevin Millikin (Chromium) 2011/07/07 08:12:02 I wonder if there's a better message? Couldn't th
rossberg 2011/07/07 09:19:32 Hm, me neither. The return type morally is a Boole
proxy_prop_not_configurable: ["Trap ", "%1", " of proxy handler ", "%0", " returned non-configurable descriptor for property ", "%2"],
proxy_non_object_prop_names: ["Trap ", "%1", " returned non-object ", "%0"],
proxy_repeated_prop_name: ["Trap ", "%1", " returned repeated property name ", "%2"],
« no previous file with comments | « no previous file | src/runtime.cc » ('j') | src/v8natives.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698