[Sync] Have ChromeInvalidationClient call OnSessionStatus on its delegate

[Sync] Have ChromeInvalidationClient call OnSessionStatus on its delegate

This makes it so that the notifications status on about:sync accurately
reflects the actual status.

BUG=88568
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91674

[akalin, 2011-07-07 00:42:31]

+zea for review

[Nicolas Zea, 2011-07-07 00:48:01]

LGTM with nit

http://codereview.chromium.org/7313018/diff/1/chrome/browser/sync/notifier/ch...
File chrome/browser/sync/notifier/chrome_invalidation_client.cc (right):

http://codereview.chromium.org/7313018/diff/1/chrome/browser/sync/notifier/ch...
chrome/browser/sync/notifier/chrome_invalidation_client.cc:121:
listener_->OnSessionStatusChanged(true);
nit: style guide prefers an enum instead of bool for params such as this.

[akalin, 2011-07-07 00:58:49]

On 2011/07/07 00:48:01, nzea wrote:
> LGTM with nit
> 
>
http://codereview.chromium.org/7313018/diff/1/chrome/browser/sync/notifier/ch...
> File chrome/browser/sync/notifier/chrome_invalidation_client.cc (right):
> 
>
http://codereview.chromium.org/7313018/diff/1/chrome/browser/sync/notifier/ch...
> chrome/browser/sync/notifier/chrome_invalidation_client.cc:121:
> listener_->OnSessionStatusChanged(true);
> nit: style guide prefers an enum instead of bool for params such as this.

You're right.  I'm not completely satisfied with representing the entire
notification state as a single bool, so I may end up developing it into
something else.  I'll check this in as a quick fix and once I come around to
reworking this I'll fix it up.

[commit-bot: I haz the power, 2011-07-07 01:12:22]

Commit queue patch verification failed without an error message.
Something went wrong, probably a crash, a hickup or simply
the monkeys went out for diner.
Ping the relevant dude on a on-needed basis.

[commit-bot: I haz the power, 2011-07-07 07:39:55]

Change committed as 91674