Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 7313018: [Sync] Have ChromeInvalidationClient call OnSessionStatus on its delegate (Closed)

Created:
9 years, 5 months ago by akalin
Modified:
9 years, 5 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana
Visibility:
Public.

Description

[Sync] Have ChromeInvalidationClient call OnSessionStatus on its delegate This makes it so that the notifications status on about:sync accurately reflects the actual status. BUG=88568 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91674

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/sync/notifier/chrome_invalidation_client.cc View 2 chunks +3 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
akalin
+zea for review
9 years, 5 months ago (2011-07-07 00:42:31 UTC) #1
Nicolas Zea
LGTM with nit http://codereview.chromium.org/7313018/diff/1/chrome/browser/sync/notifier/chrome_invalidation_client.cc File chrome/browser/sync/notifier/chrome_invalidation_client.cc (right): http://codereview.chromium.org/7313018/diff/1/chrome/browser/sync/notifier/chrome_invalidation_client.cc#newcode121 chrome/browser/sync/notifier/chrome_invalidation_client.cc:121: listener_->OnSessionStatusChanged(true); nit: style guide prefers an ...
9 years, 5 months ago (2011-07-07 00:48:01 UTC) #2
akalin
On 2011/07/07 00:48:01, nzea wrote: > LGTM with nit > > http://codereview.chromium.org/7313018/diff/1/chrome/browser/sync/notifier/chrome_invalidation_client.cc > File chrome/browser/sync/notifier/chrome_invalidation_client.cc ...
9 years, 5 months ago (2011-07-07 00:58:49 UTC) #3
commit-bot: I haz the power
Commit queue patch verification failed without an error message. Something went wrong, probably a crash, ...
9 years, 5 months ago (2011-07-07 01:12:22 UTC) #4
commit-bot: I haz the power
9 years, 5 months ago (2011-07-07 07:39:55 UTC) #5
Change committed as 91674

Powered by Google App Engine
This is Rietveld 408576698