[Sync] Have ChromeInvalidationClient call OnSessionStatus on its delegate

chrome/browser/sync/notifier/chrome_invalidation_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/notifier/chrome_invalidation_client.h"
 
 #include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
@@ skipping 100 matching lines @@
   registered_types_ = types;
   if (ticl_ready_ && registration_manager_.get()) {
     registration_manager_->SetRegisteredTypes(registered_types_);
   }
   // TODO(akalin): Clear invalidation versions for unregistered types.
 }
 
 void ChromeInvalidationClient::Ready(
     invalidation::InvalidationClient* client) {
   ticl_ready_ = true;
+  listener_->OnSessionStatusChanged(true);

[Nicolas Zea, 2011/07/07 00:48:01]

nit: style guide prefers an enum instead of bool for params such as this.

   registration_manager_->SetRegisteredTypes(registered_types_);
 }
 
 void ChromeInvalidationClient::Invalidate(
     invalidation::InvalidationClient* client,
     const invalidation::Invalidation& invalidation,
     const invalidation::AckHandle& ack_handle) {
   DCHECK(non_thread_safe_.CalledOnValidThread());
   VLOG(1) << "Invalidate: " << InvalidationToString(invalidation);
   syncable::ModelType model_type;
@@ skipping 132 matching lines @@
     const std::string& prefix,
     int prefix_length) {
   DCHECK(non_thread_safe_.CalledOnValidThread());
   VLOG(1) << "AllRegistrationsLost";
   registration_manager_->MarkAllRegistrationsLost();
 }
 
 void ChromeInvalidationClient::InformError(
     invalidation::InvalidationClient* client,
     const invalidation::ErrorInfo& error_info) {
+  listener_->OnSessionStatusChanged(false);
+  LOG(ERROR) << "Invalidation client encountered an error";
   // TODO(ghc): handle the error.
 }
 
 void ChromeInvalidationClient::WriteState(const std::string& state) {
   DCHECK(non_thread_safe_.CalledOnValidThread());
   CHECK(state_writer_);
   state_writer_->WriteState(state);
 }
 
 }  // namespace sync_notifier